[MM-493]: Fixed the bug 'don't have the permissions to create subscriptions for this project #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions for this project'
mickmister
reviewed
May 16, 2024
There was a problem hiding this comment.
Thanks for this fix @Kshitij-Katiyar 👍 LGTM, just want to make sure I understand where the code was before and how this safely fixes the issue
mickmister
added
2: Dev Review
AayushChaudhary0001
approved these changes
May 17, 2024
There was a problem hiding this comment.
This PR has been tested for the following conditions:-
- Subscriptions created for normal user access in a project(whether it is inside a group)
- Subscriptions not created for guest user access in a project(whether it is inside a group)
The above PR is working fine for all the above conditions, LGTM. Approved.
mickmister
approved these changes
May 17, 2024
mickmister
added
4: Reviews Complete
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the bug 'don't have the permissions to create subscriptions for this project'. The permissions for the guest users were not handled for groups, it was only handled for projects. Updated the condition to include group-level access as well.
Ticket Link
Fixes #493