Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logging capabilities #17

Closed
fireau1 opened this issue Jan 8, 2019 · 2 comments
Closed

add logging capabilities #17

fireau1 opened this issue Jan 8, 2019 · 2 comments

Comments

@fireau1
Copy link

fireau1 commented Jan 8, 2019

It would be very helpful if this plugin can log to mattermost log file or even its own.
@hanzei
Copy link
Collaborator

hanzei commented Jan 8, 2019

What kind of logging are you talking about? All http requests?

@hanzei hanzei mentioned this issue Jan 8, 2019
Closed
@fireau1
Copy link
Author

fireau1 commented Jan 8, 2019

logging for the purpose of debugging the plugin. Now we do not know why the plugin is not working.

@hanzei hanzei mentioned this issue Jan 8, 2019
Merged
hanzei added a commit that referenced this issue Jan 8, 2019
@hanzei
Add logging of http requests
4d4f93c 
See #17
jwilander pushed a commit that referenced this issue Jan 15, 2019
@hanzei @jwilander
Improve error handling and logging (#16)
f2a3ff1 
* Improve error handling

This commits improves the error handling by not longer returning 200 for 
invalid JSON requests.

It also rewrites the code to use idiomatic error handling.

* Add logging of http requests

See #17

* Require teamName

* Improve debug message

* Check attachment

* Post debug messages for failed webhook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanzei @fireau1