-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jira setup have minor UX issues with the subscriptions step #939
Comments
@DHaussermann The string mentioned to be improved in the issue is present in the modal, which renders while setting up the plugin and displays the URL to be used for creating the webhook. One easy fix that I tried was to use markdown here, like |
@Kshitij-Katiyar I think the scrolling thing is the most important thing to solve here, as that modal is simply not supposed to work that way. Having it rendered as a markdown "link" instead of "code" should let the user right-click and select "Copy link address". Not sure if we need anything else here. The "click here to copy" seems overkill for the interactive dialogs.
I'm not sure what this means |
@mickmister is this what we are looking for ? |
I was thinking it would show the full URL. This screenshot makes me think I should click that link to learn more about webhook URLs. @DHaussermann What do you think? |
@mickmister What do you think about this |
@Kshitij-Katiyar I'm thinking the URL should be on its own after the paragraph. Otherwise, it's difficult to parse the explanation text versus the text intended for computers (the URL). This sort of thing is not really my specialty though. @DHaussermann What do you think? |
@mickmister @DHaussermann I tried to keep it in a separate paragraph by putting /n before and after the URL but for some reason, this is not working maybe this is not supported in the modal generated from the backend I guess |
@Kshitij-Katiyar There may be an issue in the way the dialog is rendering markdown https://github.com/mattermost/mattermost/blob/master/webapp/channels/src/components/interactive_dialog/dialog_introduction_text.tsx Another thought, does the triple backtick code block as an option:
|
@mickmister Triple backticks are currently in use in the master branch and they are not working as intended. As you said there may be an issue in the way the dialog is rendering markdown. |
@Kshitij-Katiyar Okay how about we do the hyperlink approach like #939 (comment), but we put the link at the end of the paragraph? |
@Kshitij-Katiyar sorry for the late reply. |
@mickmister @DHaussermann Please share your opinion about this setup. There is a '\n' between the Paragraph and link but it is not working |
@Kshitij-Katiyar , I don't this will work well without the line-break. Can we explore why it's not working? |
@mkdbns @mickmister |
@Kshitij-Katiyar Are you able to open a PR so we can see the changes thus far? @cwarnermm Do you have any advice on how we should word/structure the above message? This is formatted markdown in the modal |
Thanks, @mickmister. I've provided text feedback via #983 |
Closing via #983 |
The subscriptions step pf setup should be improved.
It currently looks like this
There are 2 issues here.
We have buttons elswhere in the setup that have this styling...
The text was updated successfully, but these errors were encountered: