Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing return #19

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Fix missing return #19

merged 1 commit into from
Jan 24, 2019

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Jan 24, 2019

I missed an return in #16. Because of this attachment could be nil which caused ParseSlackAttachment() to panic and cause the problem reported in #15 (comment).

I will submit a PR to mattermost-server to also fix this server-side.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jan 24, 2019
@hanzei hanzei requested review from levb and jwilander January 24, 2019 08:32
levb
levb approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 24, 2019
@hanzei hanzei merged commit 5c62e89 into master Jan 24, 2019
@hanzei hanzei deleted the fix_return branch January 24, 2019 14:24
@hanzei hanzei mentioned this pull request Jan 25, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levb levb levb approved these changes

@jwilander jwilander jwilander approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @levb @jwilander