Fix "Create issue modal crashes when assignee is selected before switching projects" #834

sanjaydemansol · 2022-02-08T13:17:38Z

Summary

Ticket Link

Fixes #819

mattermod · 2022-02-08T13:17:41Z

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hanzei · 2022-02-08T13:31:43Z

@sanjaydemansol FYI: There are some linter issues: https://app.circleci.com/pipelines/github/mattermost/mattermost-plugin-jira/2743/workflows/09066f8a-6b9b-4af5-9af6-46e8d50a2db8/jobs/8608

sanjaydemansol · 2022-02-08T13:32:12Z

@hanzei yes. checking it

codecov-commenter · 2022-02-08T13:44:21Z

Codecov Report

Merging #834 (404b23c) into master (b62a305) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 404b23c differs from pull request most recent head cc69d97. Consider uploading reports for the commit cc69d97 to get more accurate results

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   34.84%   34.81%   -0.04%     
==========================================
  Files          52       52              
  Lines        5949     5949              
==========================================
- Hits         2073     2071       -2     
- Misses       3664     3666       +2     
  Partials      212      212

Impacted Files	Coverage Δ
server/subscribe.go	`66.85% <0.00%> (-0.38%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62a305...cc69d97. Read the comment docs.

…breaking changes (mattermost#818)

dipak-demansol

LGTM
Note :- Non Blocking note that, this PR binary file is not working (crash when i enable it) in the demansol-sandbox server 6.3 but the same binary is working on My stagingTK server 6.3

maisnamrajusingh · 2022-02-10T08:40:09Z

@mickmister over to you and @levb

mickmister · 2022-02-10T15:57:19Z

webapp/src/components/data_selectors/backend_selector.tsx

+                label: (
+                    <span>
+                        <img
+                            src={v.avatarUrls[AvatarSize.SMALL]}
+                            style={{width: '24px', marginRight: '10px'}}
+                        />
+                        <span>{v.displayName}</span>
+                    </span>
+                ),


Hi @sanjaydemansol, I'm not sure how this fixes the issue, mainly because I don't know what the problem originally was that was causing the crash. Do you mind explaining what the problem is, and how this PR solves it?

This component backend_selector.tsx is meant for general purpose autocomplete functionality, so we shouldn't have anything to do with users or avatars in this file. Why are you thinking this fix needs to go here?

@mickmister There was v assigned to label and that was an object, because of that it was not able to render it properly.

@sanjaydemansol I'm thinking the assignee-specific change needs to be applied to https://github.com/mattermost/mattermost-plugin-jira/blob/master/webapp/src/components/data_selectors/jira_user_selector/jira_user_selector.tsx. It makes sense if there's also a small change needed in backend_selector.tsx, but we shouldn't be referencing anything to do with avatars in this file.

Also if you accidentally leave out a mention in your comment, can you please create a new comment, rather than editing the comment to include the mention? I didn't get a notification because of this, and I just happened to have the tab open and saw your comment here 🙂

@mickmister I'll remove avatar, as you've suggested here (#834 (comment)).
I'll check and put specific and which won't generate error at label.

@mickmister code updated, removed avatar and code is not generating any errors.

code is not generating any errors.

@sanjaydemansol To be clear: Before your fix, the webapp was crashing correct? And after your fix, it is not crashing.

mickmister · 2022-02-18T15:30:54Z

webapp/src/components/data_selectors/backend_selector.tsx

@@ -8,7 +8,7 @@ import AsyncSelect from 'react-select/async';

 import {Theme} from 'mattermost-redux/types/preferences';

-import {IssueMetadata, ReactSelectOption, JiraIssue, SearchIssueParams, APIResponse} from 'types/model';
+import {IssueMetadata, ReactSelectOption, JiraIssue, SearchIssueParams, APIResponse, AvatarSize} from 'types/model';


This import should be removed

mickmister · 2022-02-18T15:33:30Z

webapp/src/components/data_selectors/backend_selector.tsx

            return {
-                label: v,
+                label: v.displayName,
                value: v,
            };


@sanjaydemansol Can you please explain this fix? All other types of selectors (non-user) seem to be working correctly. Do they actually need to have this change (which they do receive the change if it is applied in this file)? It seems the problem is specific to users, so I would expect the fix to go into jira_user_selector.tsx.

Can you please describe how you discovered the root cause, and how this fixes it? What is the error printed to the console during the crash, and what line does it occur on?

@mickmister this is unrelated to the issue. I'm not sure why it is here. I have updated the code to remove this. The crash is caused by the assignee property not being reset. I am awaiting dipak to finish the qa on this one.

DHaussermann · 2022-02-22T18:58:35Z

@hanzei Do you know if someone else able to implement the feedback suggested above instead of @sanjaydemansol?

hanzei · 2022-02-23T09:25:26Z

@maisnamrajusingh Who is taking ownership of this PR?

* wip - first wizard works * wip * wip * wip * first steps cloud + new flow * Cloud working, complete sans copy, images * cleanup * more cleanup * go.mod * Updates to flow lib * Added delegation * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * PR feedback: copy * go mod tidy * Added Jira Server flow * adjusted IsJiraAccessible test * Update server/setup_flow.go Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> * Update server/setup_flow.go Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> * PR feeback * cloud subtype text, not url * PR feedback, fixed public key encoding * go.mod point at the latest plugin-api * PR feeback and fixes * Removed skip button * Removed SKIP button * Added telemetry * fixed a crash in telemetry * copy consistency * fixed delegate complete notification, connect was not working, now done * Fixed webhook URL display escaping * Finished draft copy * Added announcement to channel steps * Fixed capitalization in titles * Update server/command_test.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/command_test.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/command_test.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/command_test.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/command_test.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/command_test.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/utils/utils.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/utils/utils.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * copy/test fixups * PR Feedback: delegate step, copy, style * Copy changes (mattermost#838) * Update text Some small text changes * Jira update text * Updates commit up to line 267 * Additonal text changes. * lint * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * Update server/setup_flow.go Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * PR feedback: copy Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com> Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> * PR feedback: cancel and done * PR feedback: webhook copy * PR feedback: removed 'Confirmed' title as redundant * Removed stats, added daily telemetry (mattermost#836) * Removed stats, added daily telemetry * lint * Fixed webhook URL display escaping * Finished draft copy * go.mod like github * added the hooks * PR feedback: copy * PR feedback: go.mod clean comment * Flow Step.WithImage changes, gofmt * Updated configure webhook screenshot Co-authored-by: Lev Brouk <levbrouk@levs-mbp.lan> Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: Aaron Rothschild <aaron.rothschild@gmail.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

maisnamrajusingh · 2022-02-28T08:01:56Z

@maisnamrajusingh Who is taking ownership of this PR?

im taking over @hanzei

Co-authored-by: Lev Brouk <lev@mattermost.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

…ra into mm-819

maisnamrajusingh · 2022-03-03T04:40:52Z

@DHaussermann I'm sending out a pr that fixes this. right now @dipak-demansol is doing qa on it.

maisnamrajusingh · 2022-03-08T05:39:21Z

@mickmister closing this one and opening another one as there are lots of unrelated changes

- fix mattermost#819

39bd207

sanjaydemansol requested a review from mickmister as a code owner February 8, 2022 13:17

mattermod added the Contributor label Feb 8, 2022

hanzei added the Work In Progress Not yet ready for review label Feb 8, 2022

hanzei removed the request for review from mickmister February 8, 2022 13:31

mickmister changed the title ~~- fix #819~~ Fix "Create issue modal crashes when assignee is selected before switching projects" Feb 8, 2022

- fix linting problem

7ef57a5

dipak-demansol requested review from hanzei and mickmister February 8, 2022 14:11

hanzei requested a review from levb February 8, 2022 14:25

hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Work In Progress Not yet ready for review labels Feb 8, 2022

hanzei added this to the v3.2.0 milestone Feb 8, 2022

dipak-demansol self-requested a review February 9, 2022 10:24

[MM-39399] Bump min_server_version due to imported server dependency …

c6a6f00

…breaking changes (mattermost#818)

hanzei removed their request for review February 9, 2022 12:07

dipak-demansol approved these changes Feb 9, 2022

View reviewed changes

dipak-demansol added Do Not Merge Should not be merged until this label is removed QA Review Done PR has been approved by QA and removed Do Not Merge Should not be merged until this label is removed 3: QA Review Requires review by a QA tester labels Feb 9, 2022

mickmister reviewed Feb 10, 2022

View reviewed changes

- feedback mattermost#834

404b23c

hanzei requested a review from mickmister February 15, 2022 13:42

mickmister reviewed Feb 18, 2022

View reviewed changes

hanzei added the Awaiting Submitter Action Blocked on the author label Feb 22, 2022

DHaussermann added 3: QA Review Requires review by a QA tester and removed QA Review Done PR has been approved by QA labels Feb 22, 2022

hanzei assigned maisnamrajusingh Feb 28, 2022

Require Mattermost 6.5.0 (mattermost#844)

39352da

hanzei modified the milestones: v3.2.0, v3.3.0 Mar 1, 2022

levb and others added 3 commits March 1, 2022 09:05

Removed EnableWebhookEventLogging setting (mattermost#847)

6abe3ca

Bump version to 3.2.0 (mattermost#846)

f986c15

Co-authored-by: Lev Brouk <lev@mattermost.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

Merge branch 'mm-819' of github.com:demansoltech/mattermost-plugin-ji…

c1dfb51

…ra into mm-819

maisnamrajusingh added 3 commits March 3, 2022 04:41

removed unused code

faa5cab

updated logic to fix issue with crashing modal

9a54eca

reverted package.json

cc69d97

maisnamrajusingh closed this Mar 8, 2022

mattermod removed the Awaiting Submitter Action Blocked on the author label Mar 8, 2022

hanzei added Invalid This doesn't seem right and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 8, 2022

hanzei removed this from the v3.3.0 milestone Mar 8, 2022

Kshitij-Katiyar mentioned this pull request Oct 19, 2022

[GH-819]:Create issue modal crashes when assignee is selected before switching projects #879

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix "Create issue modal crashes when assignee is selected before switching projects" #834

Fix "Create issue modal crashes when assignee is selected before switching projects" #834

sanjaydemansol commented Feb 8, 2022 •

edited by mickmister

Loading

mattermod commented Feb 8, 2022

hanzei commented Feb 8, 2022

sanjaydemansol commented Feb 8, 2022

codecov-commenter commented Feb 8, 2022 •

edited

Loading

dipak-demansol left a comment

maisnamrajusingh commented Feb 10, 2022 •

edited

Loading

mickmister Feb 10, 2022

mickmister Feb 10, 2022

sanjaydemansol Feb 10, 2022 •

edited

Loading

mickmister Feb 10, 2022

mickmister Feb 10, 2022

sanjaydemansol Feb 11, 2022

sanjaydemansol Feb 11, 2022

mickmister Feb 18, 2022

mickmister Feb 18, 2022

mickmister Feb 18, 2022

maisnamrajusingh Mar 8, 2022

DHaussermann commented Feb 22, 2022

hanzei commented Feb 23, 2022

maisnamrajusingh commented Feb 28, 2022

maisnamrajusingh commented Mar 3, 2022

maisnamrajusingh commented Mar 8, 2022

Fix "Create issue modal crashes when assignee is selected before switching projects" #834

Fix "Create issue modal crashes when assignee is selected before switching projects" #834

Conversation

sanjaydemansol commented Feb 8, 2022 • edited by mickmister Loading

Summary

Ticket Link

mattermod commented Feb 8, 2022

hanzei commented Feb 8, 2022

sanjaydemansol commented Feb 8, 2022

codecov-commenter commented Feb 8, 2022 • edited Loading

Codecov Report

dipak-demansol left a comment

Choose a reason for hiding this comment

maisnamrajusingh commented Feb 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanjaydemansol Feb 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DHaussermann commented Feb 22, 2022

hanzei commented Feb 23, 2022

maisnamrajusingh commented Feb 28, 2022

maisnamrajusingh commented Mar 3, 2022

maisnamrajusingh commented Mar 8, 2022

sanjaydemansol commented Feb 8, 2022 •

edited by mickmister

Loading

codecov-commenter commented Feb 8, 2022 •

edited

Loading

maisnamrajusingh commented Feb 10, 2022 •

edited

Loading

sanjaydemansol Feb 10, 2022 •

edited

Loading