switched away from deprecated GetCreateIssueMeta to get the list of p… #849
Conversation
levb
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
- Coverage 31.46% 31.25% -0.21%
==========================================
Files 49 49
Lines 5982 6015 +33
==========================================
- Hits 1882 1880 -2
- Misses 3911 3946 +35
Partials 189 189
Continue to review full report at Codecov.
|
| IsLast bool `json:"isLast"` | ||
| } | ||
|
|
||
| remaining := 50 |
There was a problem hiding this comment.
@levb - just to confirm, this value looks to be useful only when limit is 0. Since we use only "-1" as a value in the negative spectrum, maybe we could've used limit = 0 to indicate fetchAll and only pass >= 0 values for limit instead. 0/5
There was a problem hiding this comment.
Yes, the default. The limit is not currently used anywhere, we always use -1 to get all projects.
There was a problem hiding this comment.
Also, when we fetch all (-1), we do it 50 at a time.
| for _, issue := range prj.IssueTypes { | ||
| if issue.Subtasks { | ||
| if issue.Subtask { |
There was a problem hiding this comment.
Interesting change here
|
@levb @dipak-demansol and I are unable to reproduce this on Cloud or Server with the production Jira release. In both cases 50+ projects can be loaded into the Jira create issue modal. Perhaps there is more detail about what functionality is affected in a Jira task somewhere. Note we could just regression test but, I'd feel more confident if we can see the issue manifesting. |
|
1/5 regression testing is all that is needed. @DHaussermann |
There was a problem hiding this comment.
Tested and passed
We were unable to reproduce the original customer report however using Lev's new mechanism for retrieving the projects was regression tested.
- Confirmed with datasets between 50 - 100 projects
- All projects are shown in the issue create modal
- All projects are showing in subscription edit modal
- No related error found in browser console when using the functionality
- Tested on browser and Desktop
LGTM!
dipak-demansol
added
QA Review Done
There was a customer report that not all projects were showing in the project list ("edit subscription")
This PR switches away from using the
GetCreateIssueMetawhich is deprecated, in favor of cloud|server-specific APIs to get the list of all projects.cc @hanzei