Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built info via /jira about #916

Merged
merged 7 commits into from
May 31, 2023
Merged

Add built info via /jira about #916

merged 7 commits into from
May 31, 2023

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Feb 23, 2023

Summary

Make use of mattermost/mattermost-plugin-api#121. See mattermost/mattermost-plugin-github#598 and mattermost/mattermost-plugin-gitlab#362.

The PR also split the built info from /jira info into a separate /jira about. This has the benefit of /jira about only containing non -confidential information, which can be used in an issue report.

Ticket Link

None

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Feb 23, 2023
@hanzei hanzei requested a review from srkgupta February 23, 2023 22:41
@hanzei hanzei added this to the v3.3.0 milestone Feb 23, 2023
plugin.json Outdated Show resolved Hide resolved
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: -0.02 ⚠️

Comparison is base (292b5bc) 31.18% compared to head (785f638) 31.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   31.18%   31.16%   -0.02%     
==========================================
  Files          50       50              
  Lines        7405     7409       +4     
==========================================
  Hits         2309     2309              
- Misses       4905     4909       +4     
  Partials      191      191              
Impacted Files Coverage Δ
server/setup_flow.go 0.00% <0.00%> (ø)
server/telemetry.go 0.00% <0.00%> (ø)
server/user_cloud.go 0.00% <0.00%> (ø)
server/user_server.go 7.54% <0.00%> (ø)
server/command.go 16.01% <8.33%> (-0.06%) ⬇️
server/kv.go 18.26% <33.33%> (ø)
server/plugin.go 11.61% <50.00%> (-0.05%) ⬇️
server/instance.go 100.00% <100.00%> (ø)
server/issue_parser.go 70.00% <100.00%> (ø)
server/subscribe.go 65.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just one request to change /jira info to /jira me

server/command.go Outdated Show resolved Hide resolved
server/command.go Outdated Show resolved Hide resolved
@hanzei hanzei requested a review from DHaussermann May 22, 2023 20:33
@hanzei hanzei added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels May 22, 2023
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • info has been removed
  • Details from info have now been split into about and me
  • Confirmed the new commands are not restricted by MM role as I would expect

No issues found.

LGTM!

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • info has been removed
  • Details from info have now been split into about and me
  • Confirmed the new commands are not restricted by MM role as I would expect

No issues found.

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 31, 2023
@hanzei hanzei merged commit 7c1b921 into master May 31, 2023
@hanzei hanzei deleted the build_info branch May 31, 2023 19:14
@mickmister mickmister mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants