Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix telemetry hook race locally #935

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix telemetry hook race locally #935

merged 2 commits into from
Apr 27, 2023

Conversation

trilopin
Copy link
Contributor

@trilopin trilopin commented Apr 26, 2023 •
edited
Loading

Summary

Configure telemetry fixes locally to avoid increasing min_server_version (rollbacked to 6.5.2)

This fixes the problems introduced by #930.

Events can be tested through logs and rudder-dev.
Example log:

{"timestamp":"2023-04-26 11:52:51.310 +02:00","level":"debug","msg":"Tracked plugin telemetry event `jira_userConnected`","caller":"app/plugin_api.go:970","plugin_id":"jira"}

This locally copied telemetry package can be removed in favor of mattermost-plugin-api@0.1.3 when we can safely upgrade min_server_version to 7.4.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-51548

@trilopin trilopin requested a review from m1lt0n April 26, 2023 09:58
@trilopin trilopin added the 2: Dev Review Requires review by a core committer label Apr 26, 2023
@trilopin trilopin added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 27, 2023
@trilopin trilopin added this to the v3.2.5 milestone Apr 27, 2023
@trilopin trilopin changed the base branch from master to release-3.2 April 27, 2023 07:44
@trilopin trilopin changed the base branch from release-3.2 to master April 27, 2023 07:44
@trilopin trilopin merged commit 0ba44b3 into master Apr 27, 2023
@trilopin trilopin deleted the fix-telemetry-hook-race-locally branch April 27, 2023 10:03
trilopin added a commit that referenced this pull request May 3, 2023
@trilopin
Fix telemetry hook race locally (#935)
695edcd 
Configure telemetry fixes locally to avoid increasing min_server_version (rollbacked to 6.5.2)

This fixes the problems introduced by #930.

This locally copied telemetry package can be removed in favor of mattermost-plugin-api@0.1.3 when we can safely upgrade min_server_version to 7.4.

Fixes https://mattermost.atlassian.net/browse/MM-51548
@trilopin trilopin mentioned this pull request May 3, 2023
Merged
trilopin added a commit that referenced this pull request May 8, 2023
@trilopin
Release 3.2.5 (#937)
acca43d 
- #929
- #930
- #935
- Revert migration to go1.18 done in one of the cherry-picked prs, go version kept as go1.13 to avoid all migration of ioutil (migrated as part of model.AppError change)
- Bump 3.2.5

Fixes
- Telemetry race condition
- Telemetry rudder keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1lt0n m1lt0n m1lt0n approved these changes

@mickmister mickmister mickmister approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v3.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@trilopin @m1lt0n @mickmister