Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-558] Fix issue: /jira assign should accept @username #938

Merged
merged 24 commits into from
Dec 1, 2023
Merged

[GH-558] Fix issue: /jira assign should accept @username #938

merged 24 commits into from
Dec 1, 2023

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

Most of the changes in this PR are from PR #863. We just added the support to search for Jira users in case the @ symbol is not present as the prefix in the username (i.e. the approach which was being used earlier). Also, we fixed a small issue, in case the mentioned user account was not connected to Jira, the Jira issue was getting unassigned.

Demo video

screen-capture.6.webm

Ticket

Fixes #558 ( /jira assign should accept @username)

javaguirre and others added 22 commits October 4, 2022 11:05
@javaguirre
Jira assign working with AccountID
6ebca97
@javaguirre
Fix naming, joining test cases for jira user mentions
f32f93a
@javaguirre
Fix linting
ae33f3b
@javaguirre
Remove @ from user mention if any
5311780
@javaguirre
add errors when mention not found or in Jira
48ab69f
@javaguirre
Fix linting
c0532ba
@javaguirre
Fix Get mentions func definition format
9e1c4cd
@javaguirre
Renaming jiraUser to assignee
c687107
@javaguirre
remove space on func definition
5ee65c3
@javaguirre
Adding failed executeAssign test cases
782dcd1
@mattermost-build
Merge branch 'master' into feature/issue-558
fbb9202
@raghavaggarwal2308
Merge branch 'feature/issue-558' of github.com:javaguirre/mattermost-…
699d301 
…plugin-jira into MI-3051
@raghavaggarwal2308
[MI-3051] Fix issues:
45f154b 
1. Search jira users in case @ is not a prefix in username
2. Ticket getting unassigned in case the mentioned user is not connected to jira
@raghavaggarwal2308
[MI-3051] Minor code refactoring
4db58e1
@raghavaggarwal2308
[MI-3051] Review fixes
8076b5c
@raghavaggarwal2308
[MI-3051] Review fixes
8483d01
@raghavaggarwal2308 @ayusht2810
[MI-3051] Review fixes
3db575f 
Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
@raghavaggarwal2308
[MI-3051] Fix failing tests
ff90b47
@raghavaggarwal2308
[MI-3051] Review fixes
e2e781c
@raghavaggarwal2308
[MI-3051] Fix failing tests
32b980f
@raghavaggarwal2308
[MI-3051] Review fixes
668f4e4
@raghavaggarwal2308
Merge pull request #48 from Brightscout/MI-3051
9f03f03 
Fix issue mattermost#558: /jira assign should accept @username
@mattermost-build
Copy link
Contributor

Hello @raghavaggarwal2308,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mickmister
mickmister approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments

server/user.go Outdated Show resolved Hide resolved
server/user_test.go Show resolved Hide resolved
@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 4, 2023
@raghavaggarwal2308
Copy link
Contributor Author

@mickmister Fixed the review comments mentioned by you

srkgupta
srkgupta approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raghavaggarwal2308. LGTM 🎉

@mickmister mickmister removed the 2: Dev Review Requires review by a core committer label May 5, 2023
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@raghavaggarwal2308
Copy link
Contributor Author

@DHaussermann Gentle reminder for review

4 similar comments
@raghavaggarwal2308
Copy link
Contributor Author

@DHaussermann Gentle reminder for review

@raghavaggarwal2308
Copy link
Contributor Author

@DHaussermann Gentle reminder for review

@raghavaggarwal2308
Copy link
Contributor Author

@DHaussermann Gentle reminder for review

@raghavaggarwal2308
Copy link
Contributor Author

@DHaussermann Gentle reminder for review

@hanzei
Copy link
Collaborator

hanzei commented Sep 1, 2023

@AayushChaudhary0001 Would you be open to reviewing this PR?

@hanzei hanzei requested review from AayushChaudhary0001 and removed request for DHaussermann October 16, 2023 20:43
@AayushChaudhary0001
Copy link

Tested and approved,LGTM
Working fine in all the above scenarios.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Dec 1, 2023
@hanzei hanzei added this to the v4.0.0 milestone Dec 1, 2023
@hanzei hanzei merged commit 8657e65 into mattermost:master Dec 1, 2023
7 checks passed
@mickmister mickmister mentioned this pull request Dec 20, 2023
Merged
@avas27JTG avas27JTG modified the milestones: v4.0.0, v4.1.0 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@mickmister mickmister mickmister approved these changes

@srkgupta srkgupta srkgupta approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

/jira assign should accept @username
9 participants
@raghavaggarwal2308 @mattermost-build @hanzei @AayushChaudhary0001 @srkgupta @mickmister @avas27JTG @javaguirre @Kshitij-Katiyar