feat: Enable multiarchitecture builds #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toninis
requested review from
spirosoik,
stafot,
saturninoabril,
mvitale1989 and
phoinixgrr
phoinixgrr
reviewed
Feb 28, 2024
phoinixgrr
suggested changes
Feb 28, 2024
There was a problem hiding this comment.
Hadolint linter also throws some suggestions, causing the CI to fail:
-:1 DL3029 warning: Do not use --platform flag with FROM
-:9 DL3045 warning: `COPY` to a relative destination without `WORKDIR` set.
-:12 DL3029 warning: Do not use --platform flag with FROM
Let's either tackle those, or if deemed necessary ignore them.
phoinixgrr
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable multi arch docker build for push proxy
Ticket Link
https://mattermost.atlassian.net/browse/CLD-7247