Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

[MM-27142] Change dollar_per_seat to price_per_seat #1251

Merged
merged 2 commits into from
Oct 1, 2020
Merged

[MM-27142] Change dollar_per_seat to price_per_seat #1251

merged 2 commits into from
Oct 1, 2020

Conversation

nickmisasi
Copy link
Contributor

@nickmisasi nickmisasi commented Sep 29, 2020 •
edited
Loading

Summary

This was changed in mattermost-server but the change was not made here.

Ticket Link

https://mattermost.atlassian.net/browse/MM-28197

@nickmisasi nickmisasi changed the title Change dollar_per_seat to price_per_seat [MM-28197] Change dollar_per_seat to price_per_seat Sep 29, 2020
@nickmisasi nickmisasi mentioned this pull request Sep 29, 2020
Merged
@nickmisasi nickmisasi changed the title [MM-28197] Change dollar_per_seat to price_per_seat [MM-27142] Change dollar_per_seat to price_per_seat Sep 29, 2020
marianunez
marianunez suggested changes Sep 29, 2020
View reviewed changes
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe now that the server has changed that it may not be receiving the price properly from CWS given that it's still defined there as dollars_per_seat. We may need to set server and webapp back if we don't want to change CWS as well.

@nickmisasi nickmisasi merged commit d208d32 into master Oct 1, 2020
@nickmisasi nickmisasi deleted the inapp-purchase-fixes branch October 1, 2020 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinbinnie devinbinnie devinbinnie approved these changes

@marianunez marianunez marianunez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickmisasi @marianunez @devinbinnie