Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-29034] Remove usage of sidebar-text-## CSS variables #6634

Merged
merged 1 commit into from
Oct 7, 2020
Merged

[MM-29034] Remove usage of sidebar-text-## CSS variables #6634

merged 1 commit into from
Oct 7, 2020

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented Oct 5, 2020

Summary

Remove usage of sidebar-text-## CSS variables
Also fixes a forgotten --sidebar-text-16 occurence left during a previous refactoring

Ticket Link

Fixes mattermost/mattermost#15782
JIRA: https://mattermost.atlassian.net/browse/MM-29034

@KuSh
Remove usage of sidebar-text-## CSS variables
78b7413 
Fixes mattermost/mattermost#15782

Also fixes a forgotten --sidebar-text-16 occurence left during a previous refactoring
@mattermod
Copy link
Contributor

Hello @KuSh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@jasonblais jasonblais added the 2: Dev Review Requires review by a core commiter label Oct 5, 2020
@jasonblais
Copy link
Contributor

Thanks @KuSh for the contribution!

@hmhealey wasn't sure if this needs PM review - if so, please request ESethna's review.

@asaadmahmood
Copy link
Contributor

@KuSh I haven't tested this, but does this work?
I think there is an issue where css variables don't work well with numeric values, rather work well with other css variables for the opacities themselves.

@KuSh
Copy link
Contributor Author

KuSh commented Oct 5, 2020 •
edited
Loading

@KuSh I haven't tested this, but does this work?
I think there is an issue where css variables don't work well with numeric values, rather work well with other css variables for the opacities themselves.

@asaadmahmood I'll launch the app to test those changes but it would be really strange on your side to specifically ask for a change (see issue content) that is known to not work ...
It's also not the first commit to change such type of code ... (see for example 3494e9d)

@asaadmahmood
Copy link
Contributor

asaadmahmood commented Oct 5, 2020 •
edited
Loading

@KuSh Scratch that then, just had a look, looks good to me! Apologies for that.

@KuSh
Copy link
Contributor Author

KuSh commented Oct 5, 2020 •
edited
Loading

@asaadmahmood I'll launch the app to test those changes

Just tested the change (after battling a little bit with dev env :)) and I can confirm that it works as expected

@jasonblais
Copy link
Contributor

Thanks @KuSh! We'll also be labeling PRs with hacktoberfest-accepted label soon, so it counts towards your Hacktoberfest contributions!

@jasonblais jasonblais added 3: QA Review Requires review by a QA tester hacktoberfest-accepted labels Oct 6, 2020
hmhealey
hmhealey approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help with this! Looks good to me

@hmhealey hmhealey added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed 2: Dev Review Requires review by a core commiter labels Oct 6, 2020
jgilliam17
jgilliam17 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @KuSh
Tested, looks good to merge.

  • Verified sidebar text in light and dark themes - es expected.

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Oct 6, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@hanzei hanzei merged commit 54bd77b into mattermost:master Oct 7, 2020
@hanzei hanzei added this to the v5.30.0 milestone Oct 7, 2020
@KuSh KuSh deleted the issue/15782 branch October 7, 2020 09:09
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 7, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 10, 2020
Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
8f76d21 
…o MM-20499

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (71 commits)
  Fix bot icon heigth (mattermost#6578)
  Cypress/E2E: Update quick switch hint (mattermost#6691)
  migrate string-refs in search_results.jsx (mattermost#6671)
  MM-T581 Regen token (mattermost#6642)
  Switch button-bg-## to use button-bg-rgb variables (mattermost#6635)
  [MM-27142] In-Web-App purchase of Mattermost Cloud  (mattermost#6583)
  migrate user_list_row_with_error to ts (mattermost#6624)
  [MM-28217] Front-end for displaying company info (mattermost#6580)
  [MM-28211] Plan Details Card (mattermost#6582)
  [MM-28216] Billing History View (UX Only) (mattermost#6637)
  Added final set of cypress tests part of MM-29347 (mattermost#6659)
  [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167)
  Cypress/E2E: Fix channel switcher spec (mattermost#6662)
  [MM-28781] migrate string refs in channelView (mattermost#6607)
  [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643)
  [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641)
  MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633)
  [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634)
  Translations update from Weblate (mattermost#6673)
  [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547)
  ...
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 10, 2020
Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
0f3c332 
…o MM-20465

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (71 commits)
  Fix bot icon heigth (mattermost#6578)
  Cypress/E2E: Update quick switch hint (mattermost#6691)
  migrate string-refs in search_results.jsx (mattermost#6671)
  MM-T581 Regen token (mattermost#6642)
  Switch button-bg-## to use button-bg-rgb variables (mattermost#6635)
  [MM-27142] In-Web-App purchase of Mattermost Cloud  (mattermost#6583)
  migrate user_list_row_with_error to ts (mattermost#6624)
  [MM-28217] Front-end for displaying company info (mattermost#6580)
  [MM-28211] Plan Details Card (mattermost#6582)
  [MM-28216] Billing History View (UX Only) (mattermost#6637)
  Added final set of cypress tests part of MM-29347 (mattermost#6659)
  [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167)
  Cypress/E2E: Fix channel switcher spec (mattermost#6662)
  [MM-28781] migrate string refs in channelView (mattermost#6607)
  [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643)
  [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641)
  MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633)
  [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634)
  Translations update from Weblate (mattermost#6673)
  [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547)
  ...
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 10, 2020
Merge remote-tracking branch 'upstream/master' into MM-20469
02663a8 
* upstream/master: (84 commits)
  Fix bot icon heigth (mattermost#6578)
  Cypress/E2E: Update quick switch hint (mattermost#6691)
  migrate string-refs in search_results.jsx (mattermost#6671)
  MM-T581 Regen token (mattermost#6642)
  Switch button-bg-## to use button-bg-rgb variables (mattermost#6635)
  [MM-27142] In-Web-App purchase of Mattermost Cloud  (mattermost#6583)
  migrate user_list_row_with_error to ts (mattermost#6624)
  [MM-28217] Front-end for displaying company info (mattermost#6580)
  [MM-28211] Plan Details Card (mattermost#6582)
  [MM-28216] Billing History View (UX Only) (mattermost#6637)
  Added final set of cypress tests part of MM-29347 (mattermost#6659)
  [MM-24507] - Pin comment box on bottom of RHS thread (mattermost#6167)
  Cypress/E2E: Fix channel switcher spec (mattermost#6662)
  [MM-28781] migrate string refs in channelView (mattermost#6607)
  [GH-15777] Replace center-channel-color-## with center-channel-color-rgb variables (mattermost#6643)
  [GH-15776]Switch center-channel-color-## with center-channel-color-rgb variables (mattermost#6641)
  MM-29038 Removed usage of centre-channel-color from post comments (mattermost#6633)
  [MM-29034] Remove usage of sidebar-text-## CSS variables (mattermost#6634)
  Translations update from Weblate (mattermost#6673)
  [MM-20462] migrate any_team_permission_gate to typescript (mattermost#6547)
  ...
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@KuSh @jfrerich
[MM-29034] Remove usage of sidebar-text-## CSS variables (#6634)
2d0f247 
Fixes mattermost/mattermost#15782

Also fixes a forgotten --sidebar-text-16 occurence left during a previous refactoring
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
@KuSh @calebroseland
[MM-29034] Remove usage of sidebar-text-## CSS variables (#6634)
46b96ae 
Fixes mattermost/mattermost#15782

Also fixes a forgotten --sidebar-text-16 occurence left during a previous refactoring
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgilliam17 jgilliam17 jgilliam17 approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
v5.30.0
Development

Successfully merging this pull request may close these issues.

Remove usage of sidebar-text-## CSS variables
9 participants
@KuSh @mattermod @jasonblais @asaadmahmood @mm-cloud-bot @hmhealey @jgilliam17 @hanzei @amyblais