This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[MM-31934] Data retention settings page #7853
Merged
BenCookie95
merged 16 commits into
mattermost:master
from
BenCookie95:MM-31934_data-retention-settings
Apr 28, 2021
Merged
[MM-31934] Data retention settings page #7853
BenCookie95
merged 16 commits into
mattermost:master
from
BenCookie95:MM-31934_data-retention-settings
Apr 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenCookie95
requested review from
hahmadia,
anurag6713 and
sbishel
and removed request for
hahmadia
April 9, 2021 17:54
sbishel
suggested changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things. Looks good.
components/admin_console/data_retention_settings/data_retention_settings.tsx
Outdated
Show resolved
Hide resolved
components/admin_console/data_retention_settings/data_retention_settings.tsx
Outdated
Show resolved
Hide resolved
components/admin_console/data_retention_settings/data_retention_settings.tsx
Outdated
Show resolved
Hide resolved
components/admin_console/data_retention_settings/data_retention_settings.tsx
Outdated
Show resolved
Hide resolved
components/admin_console/data_retention_settings/data_retention_settings.tsx
Outdated
Show resolved
Hide resolved
anurag6713
reviewed
Apr 14, 2021
components/admin_console/data_retention_settings/data_retention_settings.tsx
Show resolved
Hide resolved
sbishel
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce, thanks for the changes.
anurag6713
approved these changes
Apr 15, 2021
furqanmlk
reviewed
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@furqanmlk I have fixed the titles! |
furqanmlk
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BenCookie95 for updating.
amyblais
added
Changelog/Done
Required changelog entry has been written
Docs/Not Needed
Does not require documentation
labels
May 5, 2021
This was referenced Sep 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3: QA Review
Requires review by a QA tester
Changelog/Done
Required changelog entry has been written
Docs/Not Needed
Does not require documentation
release-note
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the landing page for data retention.
It contains:
CustomDataRetentionEnabled
Ticket Link
https://mattermost.atlassian.net/browse/MM-31934
https://www.figma.com/file/PdZPkf36lNU6ZO41JlEjKd/Team-%26-Channel-Data-Retention?node-id=0%3A1
Related Pull Requests
There are a number of PRs open with the same changes as here, they are almost merged:
Due to the above PRs you can skip over: