Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-31934] Data retention settings page #7853

Merged

Conversation

BenCookie95
Copy link
Contributor

@BenCookie95 BenCookie95 commented Apr 9, 2021

Summary

This is the landing page for data retention.

It contains:

  • A table for the global retention policy.
  • A table for custom policies and the ability to delete a policy
  • The job table and a button to kickstart a job
  • An edit button just above the job table to edit the job time
  • The page is behind a feature flag, you will need to enable CustomDataRetentionEnabled

Ticket Link

https://mattermost.atlassian.net/browse/MM-31934
https://www.figma.com/file/PdZPkf36lNU6ZO41JlEjKd/Team-%26-Channel-Data-Retention?node-id=0%3A1

Related Pull Requests

There are a number of PRs open with the same changes as here, they are almost merged:

Due to the above PRs you can skip over:

  • components/admin_console/data_grid/
  • components/admin_console/jobs/
New data retention landing page hidden behind a feature flag. It shows the global retention settings, granular retention policies and the job table.

@BenCookie95 BenCookie95 requested review from hahmadia, anurag6713 and sbishel and removed request for hahmadia April 9, 2021 17:54
Copy link
Member

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things. Looks good.

Copy link
Member

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce, thanks for the changes.

@BenCookie95 BenCookie95 added the 3: QA Review Requires review by a QA tester label Apr 15, 2021
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

FIGMA
image

@BenCookie95
Copy link
Contributor Author

@furqanmlk I have fixed the titles!

Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenCookie95 for updating.

@BenCookie95 BenCookie95 merged commit da4cdb3 into mattermost:master Apr 28, 2021
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3: QA Review Requires review by a QA tester Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants