Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Prod test fixes #7918

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Prod test fixes #7918

merged 2 commits into from
Apr 15, 2021

Conversation

prapti
Copy link
Contributor

@prapti prapti commented Apr 14, 2021

Fixing the incoming webhook and gm reply tests:

  • Looks like the incoming webhook tests need forced clicks on the channel names.
  • The gm reply test looks like is looking for the reply sooner than it's available.

Screen Shot 2021-04-14 at 4 43 21 PM

Screen Shot 2021-04-14 at 4 40 23 PM

Screen Shot 2021-04-14 at 4 39 03 PM

Screen Shot 2021-04-14 at 4 38 06 PM

@prapti prapti added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Apr 14, 2021
josephbaylon
josephbaylon approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All tests passed locally.

@josephbaylon josephbaylon removed the 2: Dev Review Requires review by a core commiter label Apr 15, 2021
furqanmlk
furqanmlk approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally passed
image

image

image

image

@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Apr 15, 2021
@prapti prapti merged commit 455a2fd into master Apr 15, 2021
@prapti prapti deleted the prod-test-fixes branch April 15, 2021 21:55
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 15, 2021
chetanyakan added a commit to brightscout-alpha/mattermost-webapp that referenced this pull request Apr 27, 2021
@chetanyakan
Merge branch 'MM-34128' of github.com:brightscout-alpha/mattermost-we…
d3daedd 
…bapp into MM-34128

* 'MM-34128' of github.com:brightscout-alpha/mattermost-webapp: (104 commits)
  Mm 34578 add subscribe now button (mattermost#7894)
  fix subcription typo in the code (mattermost#7930)
  Fixing keys in Cypress (mattermost#7931)
  fix test on LDAP groups, code theme and incoming webhook (mattermost#7919)
  upgrade cypress to v7.1.0 (mattermost#7923)
  Adding missing Zephyr keys to existing E2E tests (mattermost#7920)
  Prod test fixes (mattermost#7918)
  [MM-11264] Added statuses to channel invite modal (mattermost#7787)
  [MM_20388/ GH_16718] Migrate 'components/signup/signup_email' module and associated tests to TypeScript (mattermost#7699)
  MM-34569 - remove step 3 to guests (mattermost#7838)
  add mfa metadata to specs accordingly (mattermost#7896)
  fix test for forgot password based on new email template (mattermost#7892)
  fix CI run of Cypress and add flag to sort specs to first (mattermost#7913)
  cast to lowercase before comparing (mattermost#7769)
  Migrating a few stragglers from the TS migration (mattermost#7770)
  update tests and keys of search date filters (mattermost#7893)
  [MM-34523] New trial card for license page (mattermost#7826)
  Feature: In-product support for Cloud Trial (mattermost#7907)
  Cypress/E2E: Update tests and keys of search date filters (remaining) (mattermost#7895)
  Mm 29656 (mattermost#7820)
  ...
This was referenced Sep 29, 2022
Open
Open
@giuesposbit giuesposbit mentioned this pull request Oct 8, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@furqanmlk furqanmlk furqanmlk approved these changes

@josephbaylon josephbaylon josephbaylon approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prapti @josephbaylon @furqanmlk @amyblais