Added functionality to archive/unarchive teams from system console

[manojmalik20]

Summary

Added feature to archive/unarchive teams from the system console

Ticket: https://mattermost.atlassian.net/browse/MM-37195

Screenshots

Release Note

Added new feature to archive and unarchive teams through the Teams section in the system console

[mattermod]

Hello @manojmalik20,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[mkraft]

@esethna I've added you for PM review and @matthewbirtch for UX review. Please redirect as appropriate.

[matthewbirtch]

Thanks for the contribution @manojmalik20! Seems like a great idea to have this feature.

Just a couple notes from me:

1. I can't seem to consistently reproduce this, but when I archive a team and save that change, it kicked me out of the system console and back in to the chat UI. Can we make sure it always routes back to the Teams listing page in the system console?

2. If I archive the currently active team, and I click 'back to {team}' in the top-left, it errors out with 'Team not found'. This makes sense, but we should consider activating the last accessed unarchived team and changing the 'back to {team}' so that it reflects that team.

3. If the server only has one team that is not archived, should we allow archiving of the one team? I wonder if the archive button should be disabled or hidden in this case - maybe with some help text to explain that 'Archiving is disabled when there is only one active team`. I tried archiving the last remaining team and as soon as I archived the last team, it kicked me out of the system console to this screen below.
   

4. For the teams list view, can we change the (Archived) color so that it's not red? Red implies an error. I would suggest going with a 56% or 64% opacity of the standard text color

[mickmister]

Thanks for the PR @manojmalik20! Mostly looks good 👍 I have a few requests

[esethna]

Adding @wiersgallak @aaronrothschild as they might have more context on system console features. If the concept of "archiving a team" didn't exist before this, then I think we need to think through what that actually means, and what happens to existing channels, users, memberships, accounts etc on that team.

[manojmalik20]

There is a WebSocket event WEBSOCKET_EVENT_DELETE_TEAM which is sent whenever a team is archived and in the event handler in the webapp, there is a redirect logic that redirects the user to the homepage(chat UI) or the welcome screen if no team is left. I was wondering how to stop that event handler to stop redirecting if the event is fired because of the Archive Team option in the system console. But doing that will also stop redirecting if the team is archived with the help of mmctl commands which can create a problem if the user deletes the currently active team. What should I do? Maybe one of the developers can help.

[mickmister]

I was wondering how to stop that event handler to stop redirecting if the event is fired because of the Archive Team option in the system console.

Since the system console is separate from the channel view, can we decouple their relationship as far as the "current team"? We could have conditional logic in the websocket handler for handling the case of being in the system console, that effectively sets the currently active team to null. Then when the user tries to navigate back to the channel view, that's when we send them to the select team page. @manojmalik20 What are your thoughts on this?

[aaronrothschild]

Adding @wiersgallak @aaronrothschild as they might have more context on system console features. If the concept of "archiving a team" didn't exist before this, then I think we need to think through what that actually means, and what happens to existing channels, users, memberships, accounts etc on that team.

I agree with this....what happens to channels? How can I find them again? Unarachive the team then unarchive the channels?

@manojmalik20 Right now, does this essentially "hide" a team without deleting it?

[manojmalik20]

I agree with this....what happens to channels? How can I find them again? Unarchive the team then unarchive the channels?

@manojmalik20 Right now, does this essentially "hide" a team without deleting it?

Yes @aaronrothschild, this essentially "hides" a team without deleting it. Once you unarchive the team, you don't have to separately unarchive channels unless they were already archived before archiving the team. So basically, on unarchiving a team, it restores back to the state in which it was before archiving.

[manojmalik20]

@mkraft @mickmister @wiersgallak Is there anything left on this PR?

[jasonblais]

Sorry for the delay, and thanks for the contribution @manojmalik20!

The last step is a QA review, I've requested @furqanmlk to help. Once completed, we're ready to merge! :)

[furqanmlk]

N/A

[furqanmlk]

Working as expected. all e2e test cases passed ✅

[mattermod]

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

[mattermod]

Trying to auto merge this PR.

[mattermod]

Pull Request successfully merged
SHA: 3ede09f

[mm-cloud-bot]

Test server destroyed

[mm-cloud-bot]

Test server destroyed

[jasonblais]

Thanks again @manojmalik20!

cc @amyblais not sure if this should have a Jira ticket for release test coverage.