This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-36235] - Do not allow to downgrade cloud plans #8268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGMETEOR
added
2: Dev Review
nickmisasi
approved these changes
Jun 16, 2021
marianunez
suggested changes
Jul 7, 2021
Comment on lines
194
to
197
| const options = Object.keys(products).map((key: string) => { | ||
| return {key: products[key].name, value: products[key].id}; | ||
| return {key: products[key].name, value: products[key].id, price: products[key].price_per_seat}; | ||
| }).sort((a, b) => a.price - b.price).filter((option) => { | ||
| return option.price >= this.state.currentProduct!.price_per_seat; |
There was a problem hiding this comment.
@AGMETEOR this code has now changed to consider the flat_fee subscriptions in this PR: https://github.com/mattermost/mattermost-webapp/pull/8341/files#diff-acb502910cc86e76a73b356eba7ef5024d0db3aaa31441bbe70ff3c83dc164beR193-R206
We can now update this PR and consider not allowing them to downgrade but ONLY when you are upgrading (not the initial purchase from trial given that they may be in Enterprise and can select Starter to subscribe)
There was a problem hiding this comment.
I have updated the code
AGMETEOR
requested review from
marianunez and
pvev
and removed request for
nickmisasi
AGMETEOR
removed
the
Do Not Merge
|
@stevemudie I think this is a post merge QA review candidate |
stevemudie
added
QA Deferred
marianunez
approved these changes
Jul 13, 2021
Comment on lines
+203
to
+204
| const flatFeeProducts: ProductOptions = []; | ||
| const userBasedProducts: ProductOptions = []; |
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if the user is subscribed in the Starter or Professional, when the admin clicks the "Upgrade" button the purchase modal shows all options. They should only be presented with the higher options to upgrade (and the current plan for comparison)
Ticket Link
MM-36235
Related PRs
webapp
Release Note