This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Cherry pick slow typing draft fixes to release-5.31 #8460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onds (#8396) * Do not save drafts until typing has stopped for X milliseconds * Fix comment box relying on draft stored in redux * Fix tests * Fix another test
…lly to fix persistence issues (#8411) * Temporarily store drafts in localStorage and rehydrate manually to fix persistence issues * Fix console error on reload immediately after typing * Null out saveDraftFrame to prevent potential double saves
jwilander
changed the title
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry picks the following fixes for slow typing performance issue related to drafts:
Release Note