MM-37299 - invite members ab testing #8491

pvev · 2021-07-28T20:40:38Z

Summary

This PR adds the invite members button call to action. The button will be shown in different places and with different shapes depending on the value set in the feature flag InviteMembersButton.
The options are:
sticky_button: sticked to the bottom of the left hand side panel
lhs_button: Just below of the direct messages users list
user_icon: at the right side of the plus (more about channels) icon at the top of the left hand side panel
none: don't show any button

Ticket Link

https://mattermost.atlassian.net/browse/MM-37299

Related Pull Requests

mattermost/mattermost#18016

Screenshots

User Icon:

Sticky:

Lhs_button:

Release Note

NONE

marianunez

Looking great! 🎉 Would be ideal if we can also get a cypress test for these cases

marianunez · 2021-07-29T00:55:07Z

components/sidebar/channel_navigator/channel_navigator.tsx

                        {addChannelDropdown}
+                        <InviteMembersButton buttonType='icon-button'/>


Based on the design, I believe the icon button should go first given that it should be on the left of the add channel button https://www.figma.com/file/xG1pcf2OiV7gXePqlUzQEi/Invite-Users-A-B-Test?node-id=18%3A217841

marianunez · 2021-07-29T00:57:13Z

packages/mattermost-redux/src/selectors/entities/preferences.ts

@@ -284,3 +284,9 @@ export function isTimedDNDEnabled(state: GlobalState): boolean {
        getFeatureFlagValue(state, 'TimedDND') === 'true'
    );
 }
+
+export function getInviteMembersButtonLocation(state: GlobalState): string | undefined {


Should this return InviteMembersBtnLocations?

marianunez · 2021-07-29T00:58:55Z

components/sidebar/channel_navigator/channel_navigator.tsx

@@ -130,6 +132,7 @@ export default class ChannelNavigator extends React.PureComponent<Props> {
                    {!this.props.showUnreadsCategory && <ChannelFilter/>}
                    {jumpToButton}
                    {addChannelDropdown}
+                    <InviteMembersButton buttonType='icon-button'/>


We should use the enum type here instead of the string

marianunez · 2021-07-29T00:59:30Z

components/sidebar/invite_members_button.tsx

+    case 'icon-button':
+        inviteButton = userIcon;
+        break;
+    case 'sticky-button':
+        inviteButton = stickyButton;
+        break;
+    case 'lhs-button':
+        inviteButton = lhsButton;
+        break;


Same here use the enum type - check for other string usages in the PR

marianunez · 2021-07-29T01:02:30Z

components/sidebar/invite_members_button.tsx

+    buttonType: string;
+};
+
+const InviteMembersButton: React.FC<Props> = (props: Props): JSX.Element | null => {


Let's add some unit tests for this new component

matthewbirtch · 2021-07-29T14:09:18Z

@pablovelezvidal how can I get the different tests to display so I can review?

Heading out for PTO. Added another reviewer to unblock this while I'm away

pvev · 2021-07-29T15:08:12Z

@pablovelezvidal how can I get the different tests to display so I can review?

Im working on getting the splitio values read from the spinwick server, once I get this done, I will let you know. If I can not get this done quickly, I can simulate the splitio value responses so you can validate the UX for this PR. I will keep you posted. @matthewbirtch

AGMETEOR

LGTM

pvev · 2021-07-30T16:19:44Z

@stevemudie @matthewbirtch This other PR #8506 contains this same code + a pipeline change so the spinwick server is updated correctly. You can do your tests there. Currently the default value for splitio is User Icon. Let me know via DM when you want me to change the values so you can see the different variations the button has.

stevemudie

Worked with Pablo to test the different invite button locations and everything worked as expected.

Thanks @pablovelezvidal !

pvev · 2021-07-30T17:26:34Z

/update-branch

matthewbirtch · 2021-07-30T17:41:34Z

Hey @pablovelezvidal a few things I've found:

User Icon Option

The new icon next to the + icon is misaligned. It's sitting 1px too low

Sticky Button Option

The button's border and text color should be full opacity of the sidebar text color.
The hover state will just be adding a background of 8% sidebar text color
The button size is too small. An update was made recently (sorry I don't think that got communicated back to you). It should be 32px in height.
The font-weight on the button label should be font-weight: 600
The font-size on the button label should be font-size: 12px
The font-size on the icon should be font-size: 14px
Can we add 4px of space between the icon and the label within the button?
Can we adjust the spacing around the button so that there is 16px of space all the way around it? And it looks like there is a min-width set on the button to 90%. If we make this padding adjustment, we should be able to make the button width 100% of its container

LHS button version

Can we mimic the style of a channel list item for this button? The icon size, the spacing should align with the channel items above

matthewbirtch

Nice work @pablovelezvidal. Based on the changes we reviewed together, I think we're good to go.

mm-cloud-bot · 2021-07-31T13:55:24Z

Test server destroyed

mm-cloud-bot · 2021-07-31T13:55:25Z

Test server destroyed

mm-cloud-bot · 2021-08-26T18:08:32Z

PR is closed/merged not creating a SpinWick Test server

…8895) * [MM-37189] fix style issue in ProductNoticesModal (#8425) * fix style issue in ProductNoticesModal * fix margin issue in productNoticesModal * fix linting error * reduce text margin * Merge 6.0 back into master (#8445) * Lock CI from master/release-6.0 (#8246) Automatic Merge * MM-36085: Split out System/Team Schemes from license feature checks. (#8211) * MM-36085: Shows the Permissions sysconsole menu item in all cases. Removes feature discovery page. * MM-36085: Remove options that are now available in the system scheme. * MM-36085: Removes unused import. Updates snap. * MM-36085: Updated translations. * MM-36085: Fixes license check. Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * Lock CI back to master. Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Claudio Costa <cstcld91@gmail.com> Co-authored-by: Martin Kraft <martinkraft@gmail.com> * Set default value of bool form field to false (#8108) * initialize boolean form value as false * consolidate tests and rename form component file * empty commit to run CI * fix: Subscription title in system console billing is singular (#8451) * Translations update from Weblate (#8455) * Translated using Weblate (Hungarian) Currently translated at 21.2% (1021 of 4814 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 20.8% (1004 of 4814 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 19.1% (920 of 4807 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 10.4% (502 of 4807 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4807 of 4807 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (German) Currently translated at 96.2% (4639 of 4819 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 92.6% (4464 of 4819 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 91.1% (4387 of 4814 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 91.1% (4386 of 4814 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 89.6% (4309 of 4807 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (German) Currently translated at 96.3% (4638 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 96.2% (4633 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 96.2% (4639 of 4819 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 92.6% (4464 of 4819 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 91.0% (4387 of 4819 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 91.1% (4386 of 4814 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 89.7% (4316 of 4807 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (German) Currently translated at 89.7% (4316 of 4807 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4819 of 4819 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4814 of 4814 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (English (Australia)) Currently translated at 100.0% (4814 of 4814 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (Bulgarian) Currently translated at 100.0% (4813 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/ Translated using Weblate (Bulgarian) Currently translated at 100.0% (4814 of 4814 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (German) Currently translated at 100.0% (4813 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4813 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 99.9% (4811 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 99.3% (4781 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 98.8% (4758 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 98.0% (4717 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 97.4% (4688 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 97.0% (4670 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 96.9% (4666 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 96.4% (4642 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 96.3% (4638 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (German) Currently translated at 100.0% (4813 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu> Co-authored-by: JtheBAB <srast@bioc.uzh.ch> Co-authored-by: jprusch <rs@schaeferbarthold.de> Co-authored-by: Danny Funkat <danny.funkat@tele-union.de> Co-authored-by: Kaya Zeren <kayazeren@gmail.com> Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au> Co-authored-by: Nikolai Zahariev <nikolaiz@yahoo.com> * Fix console error when viewing channel on an unsupported CRT client while webapp is open with CRT on (#8450) * [MM-37106] - Can't return to Getting Started flow from Threads view (#8438) * Fixes Thread in thread viewer displayed vertically (#8448) "Thread" h3 title in thread pane is displayed vertically in other languages (e.g: Japanese). This commit fixes that by enlarging the column as much as needed so text won't wrap. * MM-35392 Load thread unreads for other teams on app load (#8413) * On initial app load include threads in unreads for teams * Fix types and tests * Fixes per feedback * Innocuous change to trigger build * MM-36756 Add new component for positioning SuggestionList in RHS (#8408) * MM-36756 Add new component for positioning SuggestionList in RHS * Remove accidental comic * Address feedback * Fix type issues * [MM-36736] - Remove current self-managed initial product tour (#8440) * Translations update from Weblate (#8465) * Translated using Weblate (German) Currently translated at 100.0% (4813 of 4813 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (Chinese (Simplified)) Currently translated at 97.3% (4670 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ Translated using Weblate (Chinese (Simplified)) Currently translated at 96.6% (4634 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ * Translated using Weblate (Dutch) Currently translated at 99.6% (4781 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (English (Australia)) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (German) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Bulgarian) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/ Co-authored-by: JtheBAB <srast@bioc.uzh.ch> Co-authored-by: Kaya Zeren <kayazeren@gmail.com> Co-authored-by: aeomin <lin@aeomin.net> Co-authored-by: Tom De Moor <tom@controlaltdieliet.be> Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au> Co-authored-by: jprusch <rs@schaeferbarthold.de> Co-authored-by: Nikolai Zahariev <nikolaiz@yahoo.com> * MM-377220 Fix theming and stying of Add Users to Channel modals (#8449) * Move CSS for channel_invite_modal into its own file * MM-377220 Fix theming and stying of Add Users to Channel modals * [MM-37105] - Onboarding comes back after team or thread view switch (#8437) * [MM-37105] - Onboarding comes back after team or thread view switch * fix lint * undo * update snap * feedback impl * remove getUsers * [MM-37064] - Onboarding flow is showing for existing users (#8442) * [MM-37064] - Onboarding flow is showing for existing users * fix modal message * update * fix: drop manual capitalization (#8434) * Fixes global threads crash on md images (#8447) * Fixes global threads crash on md images MarkdownImageExpanded needs onImageHeightChanged prop to be defined, this commit adds that, but not using it, since we have fixed height for thread items. * Fixes snapshot tests * Minor refactor * [MM-37108] Only make request if server is enterprise ready (#8406) * Only make request if server is enterprise ready * Simplify * MM-36765: fixes threads crashing when LEAVE_CHANNEL (#8441) * MM-36765: fixes threads crashing when LEAVE_CHANNEL Leaving a channel removes post items that belong to that channel from posts, but it doesn't remove threads that belong to that channel, so the global threads view crashes. This commit fixes that by removing threads as well upon a LEAVE_CHANNEL action being dispatched. The way entities.threads reducer is structured it wasn't possible to update counts upon LEAVE_CHANNEL action. So this commit refactors combineReducers to a custom function to be able update counts as well. * Minor refactor * Fixes RHS crash when leaving a channel When you leave a channel and a thread belonging to that channel is open in the RHS the app would crash. This commit fixes that crash. * MM-37422: Fix Safari overflow scrolling issue (#8471) * fix: hide rhs when not open * fix: content height logic * Standardize name of suggestionListPosition (#8409) * Standardize name of suggestionListPosition * Fix bad rebase * Added warning around usage of Components * MM-36248 Fix GitLab Button Color and Text not reflecting in UI (#8320) * GitLab button text and color fix * Fixing formatting * Adding tests for gitlab and openid text and color props * Fixing lint errors * MM-36248: add open id, git lab tests * Add "playbooks" and "boards" to restricted team URLs list (#8483) * [MM-36463] Promoting beta features to GA (#8400) * moving features to GA Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MacBook-Pro.local> * removing feature flag (#8454) Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MacBook-Pro.local> * [MM-37118] Don't mark channel as read for reply posts with CRT on (#8489) * [MM-37118] Don't mark channel as read for reply posts with CRT on * move code to a better place * fix deleted message timestamp position issue (#8488) * MM36866 - mid month proration UX changes to purchase modal (#8394) * MM-36866 - mid month proration changes * Unify the validation for the team name * add the variable product name to the prorated tooltip message * fix issue with ordering and with product not getting selected correctly * do not allow downgrade from user_based to flat_fee * remove isTrial condition for changing subscription product * fix the initial load problem with currentProduct * fix linter issues * load product from global state to cause components rerendering * use useEffect instead of layoutEffect per code review recomendation Co-authored-by: Pablo Velez Vidal <pablo.velez@mattermost.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * Block only file drops, not all the kind of drops (from drag and drops) (#8311) * Remove target blank and change routes to match new plan. (#8487) * Fix console errors (#8457) * fix console errors - tabfocus on `textbox` component was marked as required, wasn't provided in `create_post`, but also wasn't used in `textbox` ... made it optional, used it in `textbox` and defaulted to `0` - direct handling of focus was removed from `settingitemmin` a while back, but still expected by `themesetting` component to be passed to `settingitemmin` ... removed * update snapshot * Cypress/E2E Maintenance: Remove old Data Retention Policy (#8444) * Add Metropolis font and apply to headings (#8402) * Add Metropolos font and apply to headings * lint auto fix * extra line not removed by auto fix * visual design tweaks to support new heading font * adjust team name spacing # Conflicts: # sass/layout/_sidebar-left.scss * badges in team header to use Open Sans * use open sans for rhs channel name * update weight for marketplace heading * dm channel heading size * fix bug with guest badge height * lint, snapshot and test updates * fix bug introduced by in-progress global header * [MM-29217] Remove Posts.ParentId (#8401) * Lock CI from master/release-6.0 (#8246) Automatic Merge * Remove Posts.ParentId Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * MM-37495: CRT, always enable mark all as unread (#8493) MM-37495: CRT, always enable mark all as unread Allows users to click the "mark all as unread" button even if there are no unread threads in the list. Currently the button is disabled unless there are unread threads. * Fixes type issue (#8500) `parent_id` has been deprecated. * fix whitespace in refresh bar (#8486) * fix whitespace in refresh bar * Update NOTICE.txt (#8502) * [MM-37377] - LHS does not update after Getting Started steps are complete (#8478) * [MM-37377] - LHS does not update after Getting Started steps are complete * fix tests * add cypress check * increment to 5 steps * fix happy path * Fix builds pointing at the wrong version (#8511) * Cypress E2E: fixed Guest and Member invitation test cases (#8504) * fixed test cases * replace cy.get * replace_cy.get * MM-37299 - invite members ab testing (#8491) * MM-37299 - invite members ab testing Co-authored-by: Pablo Velez Vidal <pablo.velez@mattermost.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * Translations update from Weblate (#8513) * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (Hungarian) Currently translated at 26.9% (1295 of 4803 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 26.8% (1290 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 25.0% (1202 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 22.1% (1061 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 21.4% (1027 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (German) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4803 of 4803 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4803 of 4803 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4803 of 4803 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (Russian) Currently translated at 99.1% (4756 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ru/ Translated using Weblate (Russian) Currently translated at 99.1% (4755 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ru/ Translated using Weblate (Russian) Currently translated at 97.2% (4667 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ru/ * Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (4803 of 4803 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (4803 of 4803 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (4803 of 4803 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ Translated using Weblate (Chinese (Simplified)) Currently translated at 99.7% (4784 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (4797 of 4797 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ * Translated using Weblate (English (Australia)) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ Translated using Weblate (English (Australia)) Currently translated at 100.0% (4803 of 4803 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (Spanish) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/es/ * Translated using Weblate (Dutch) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (Bulgarian) Currently translated at 99.5% (4785 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/ * Translated using Weblate (German) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu> Co-authored-by: JtheBAB <srast@bioc.uzh.ch> Co-authored-by: Kaya Zeren <kayazeren@gmail.com> Co-authored-by: Alexey Napalkov <flynbit@gmail.com> Co-authored-by: aeomin <lin@aeomin.net> Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au> Co-authored-by: Elias Nahum <elias@mattermost.com> Co-authored-by: Tom De Moor <tom@controlaltdieliet.be> Co-authored-by: Nikolai Zahariev <nikolaiz@yahoo.com> Co-authored-by: Elisabeth Kulzer <elisabeth.kulzer@mattermost.com> * rename view image modal to file preview modal and change imports (#8492) * [MM-18945] Migrate 'components/activity_log_modal' and associated tests to TypeScript (#8263) * migrate activity_log_modal to typescript * ref: migrate activity_log_modal to ts * fix lint errors * update tests * update tests * fix lint errors * MM-37451 integration of compass-components (#8453) * added a very basic implementation of the compass-components package * moved compass-components for ProductSwitcher to separate component * added correct usage of element in Grid component and cleaned up comments * added generic type to the Grid component to fix typing issue * added return type to GlobalHeader component * added new compass-components release from npmjs * stuff happened * bumped compasss-component package version to 0.2.3 * some changes and version bump of compass-components * fix build, update compass components, theme tweak * revert compass components integration test code ... ... to the bare minimum, we will revisit in future pr's * update comment for temp theme implementation Co-authored-by: Dean Whillier <dean@whillier.com> * Make rootId prop optional for Textbox (#8510) * ESLint overlay trigger error help message (#8518) * error overlay trigger from react-bootstrap * fix linter * fix other lint * MM-36646: removes post paddings on CRT enabled (#8495) When turning on the collapsed replies there's a big gap between the first and second consecutive post from the same person. This commit removes that gap. * Update Default Themes to new Colors/Names (#8459) * system theme updates, initial commit * fix console errors - tabfocus on `textbox` component was marked as required, wasn't provided in `create_post`, but also wasn't used in `textbox` ... made it optional, used it in `textbox` and defaulted to `0` - direct handling of focus was removed from `settingitemmin` a while back, but still expected by `themesetting` component to be passed to `settingitemmin` ... removed * update snapshot * system theme update tweaks - removed dndIndicator logic confirmed to not be needed anymore here: https://github.com/mattermost/mattermost-webapp/commit/f8406061084e27f2c4f5eb1de745b8f28b14a753 * Remove miscellaneous classname attribute * lint tweaks * updates to snapshots and tests * more updates to tests * update import theme test and component - update setThemeDefaults to no longer use the provided theme by reference, but instead to return a new copy of the modified theme * remove errant type import * fix type errors * make theme svg icons accessible * Tweak new theme colour for 6.0 - support for Global Header - switch to using theme constants in redux * remove no unused theme constants (replaced with constants from redux) * correct reversed colours * test and snapshot updates * fix bug with new thumbnail preview icon - message indicator and button bg colour variables were swapped * add flag disabling limit to Docker resource, add "@timeout_error" test metadata and only remove plugin by id (#8524) * [MM-37460] - Add tip for downloading desktop app to the Getting Started page (#8523) * [MM-37460] - Add tip for downloading desktop app to the Getting Started page * refactor * fix lint error * feedback impl * Cypress/E2E: Fix failed tests in prod (#8520) * fix failed tests in prod * update the test * Switch to using @mattermost/compass-icons package (#8501) * Switch to using @mattermost/compass-icons package * remove rogue prop in test As far as I can tell, this property doesn't exist anywher in the webapp related to post ui. * bump compass-icons version * package lock update * update compass-icons package and fix type error * add missing icon to mobile menu item * test, lint and snapshot updates * minor tweak to icon placement * [MM-37065] - No way to complete onboarding in mobile view (#8525) * [MM-37065] - No way to complete onboarding in mobile view * fix lint * fix lint * [MM-37468] Update tutorial dot (#8521) * Extract pulsating dot as its own widget. Use pulsating dot widget in status dropdown and first time user experience. * Update wording in channel_tutorial_tip * Add tutorial step for add channels. Redo main menu tutorial step * convert channel_tutorial_tip to typescript. * Migrate sidebar tutorial tip to sidebar. * Copy sidebar header dropdown and convert to typescript. * Remove unread badge for main menu marketplace item * ApplyTheme Updates – convert older changeCSS JS to CSS variables part 1 (#8399) * change sidebarBg to css var Affects: - legacy 'Switchy Channels - ⌘K' channel sidebar button background - legacy channel sidebar background - team settings modal left sidebar background - mobile phone right hamburger menu background Removed: - ‘scrollbar-face-color’ is IE only * change sidebartext to css var Changes: - user status offline icon colour - legacy channel sidebar a11y focus border - legacy channel sidebar channel icons svg fill colour - mobile right sidebar text colour - mobile right sidebar svg icon fill colour - mobile settings model nav item bottom border colour - mobile settings model nav item text colour - legacy sidebar add channel button hover/focus icon colour - legacy sidebar switch channels button background colour Other: - default a11y focus border colour (uses —link-color) * change sidebarTextHoverBg to css vars Changes: - Account settings modal nav bar button background colour - Legacy channel sidebar nav item and move button hover state background colours * change sidebarTextActiveColor to css vars Changes: - Legacy sidebar active channel background colour - Legacy sidebar active channel text colour * replace ‘var(--‘ occurances Replace uses of css vars with baked in opacity in favour of ‘rgba’ approach. * replace ‘v(‘ occurances Replace uses of css vars with baked in opacity in favour of ‘rgba’ approach. * remove css vars with baked in opacity * change sidebarHeaderBg to css vars Changes: - sidebar header status icon background colour - sidebar header background colour - post list floating timestamp background colour in mobile - team sidebar background colour (note: covered entirely by child elements) - channel header bar background in mobile Note: - ‘#status-dropdown’ no longer exists in code base - ‘sidebar--menu .team__header’ is not used anymore * change sidebarHeaderTextColor to css vars Changed: - sidebar header status foreground colour - sidebar header text colour - post list floating timestamp text & border colour in mobile - sidebar header hamburger icon colour - sidebar hamburger icon colour in mobile - sidebar header user name text colour & hover colour - mobile modal section header text colour - mobile channel header right buttons background colour - mobile emoji picker header text and icon colour Notes: - ‘.team__header’ is no longer in use - ‘.modal-title .name’ doesn’t seem to exist anymore - ‘.team-btn__content’ no longer exists * change dndIndicator to css vars Changes: - DND status icon colour Notes: - ‘.status.status--dnd’ no longer exists * change mentionBg to css vars Changed: - team/channel sidebar mention badge background colour Notes: - ‘.list-group-item’ is no longer used * change mentionColor to css vars Changed: - team/channel sidebar mention badge foreground colour Notes: - ‘.list-group-item’ is no longer used * lint updates * Remove old unused compatibility code * compatibility: re-add transparency variables * lint fix * fix bug with channel header menu icon colour * re-adding missing class name * apply svg fill colour for offline icons * Merge branch 'master' into applytheme/test-changecss-consolidated-01 # Conflicts: # sass/layout/_headers.scss # utils/utils.jsx * status icon colour fixes * lint fixes * [MM-24733] Removing slack importer from UI (#8479) * removing slack importer from UI * fixing translations Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MacBook-Pro.local> * Upgrading german to official language (#8517) * Upgrading German to official language * Upgrading German to offical language * ran update snaphot Co-authored-by: Tom De Moor <tom@controlaltdieliet.be> * MM 37062 Add new default branded theme "Denim" (#8529) * Add in new denim theme and make it the new default * snapshot update * [MM-36710] System Console "Data Retention Policies" is not supposed to be team themed (#8435) * Fixing system console styling * Fixing border to align with default theme * Making search icon fill consistent across themes * Fixing card color and background in system console * Overriding Input component to use console styles * Fixing lint errors * [MM-36710] applying console styling to Input * [MM-36710] Applying console theme to dropdown menu * [MM-36710] Fixing Input box-shadow * [MM-36710] Fixing box shadow applying to all input * [MM-36710] Adjusting search icon fill color * [MM-36710] Properly fixing search icon fill Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * MM-36977 Add PostAriaLabelDiv to reduce Post re-rendering (#8480) * Migrate utils/post_utils to TypeScript * MM-36977 Add PostAriaLabelDiv to reduce Post re-rendering * Fix type errors caused by removing injectIntl * Update missed test * Fix LatestPostReader crashing in an empty channel * Update snapshots * Fix useless test case * Fix a couple other useless tests * Be clearer about passing children * Migrate Create Post and Create Comment to typescript (#8385) * Migrate Create Post and Create Comment to typescript * Fix lint * Fix snapshots * Remove unneeded optional and unneeded casting * Fix types and add props and caret position to post draft type * Commit missing change * Fix lint * Fix test * Fix types * [MM-36175] Permalink previews (#8304) * inital component before show more functionality * latest updates * adding container and fixing some other things * fixing padding * adding link to permalink card * fixing event propagation, getting users and style fixes * making some adjustments to how we manage posts * fixing some stuff and adding snapshot tests * fixing lint * fixing tests * adding new config to admin definition * clean up for PR * fixing copy and width of container * fixing PR comments * fixing title for message previews * stop propagation and fix error * fixing link for preview * fixing link for preview * fixing translations * fixing lint * fixing tests * renaming props and code style fixes * checking post_id exists * fixing some styles * fixing link colour for show more * fixing permalink sys console copy * adding doc link * updating snapshot Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MacBook-Pro.local> Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MBP.hitronhub.home> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * Translations update from Weblate (#8546) * Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 27.9% (1343 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (Hungarian) Currently translated at 99.6% (4790 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.6% (4790 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.6% (4790 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.7% (4794 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.7% (4796 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.9% (4802 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.9% (4804 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (Swedish) Currently translated at 100.0% (4806 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (Hungarian) Currently translated at 98.9% (4745 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 98.9% (4745 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.6% (4790 of 4806 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (German) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (Japanese) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (English (Australia)) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (Dutch) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (Swedish) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ Translated using Weblate (Swedish) Currently translated at 99.7% (4783 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (4795 of 4795 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ Co-authored-by: aeomin <lin@aeomin.net> Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu> Co-authored-by: Zsolt Godó <zsolttokio@gmail.com> Co-authored-by: MArtin Johnson <martinjohnson@bahnhof.se> Co-authored-by: JtheBAB <srast@bioc.uzh.ch> Co-authored-by: kaakaa <stooner.hoe@gmail.com> Co-authored-by: Kaya Zeren <kayazeren@gmail.com> Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au> Co-authored-by: Tom De Moor <tom@controlaltdieliet.be> * [MM-37715] - Hide global header preference when the feature flag is d… (#8540) * [MM-37715] - Hide global header preference when the feature flag is disabled * fix type error in the test * Update components/user_settings/display/index.ts Co-authored-by: Caleb Roseland <caleb.roseland@mattermost.com> * Update components/user_settings/display/user_settings_display.tsx Co-authored-by: Caleb Roseland <caleb.roseland@mattermost.com> * Update components/user_settings/display/user_settings_display.test.tsx Co-authored-by: Caleb Roseland <caleb.roseland@mattermost.com> * Update components/user_settings/display/user_settings_display.tsx Co-authored-by: Caleb Roseland <caleb.roseland@mattermost.com> * import selector Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MBP.fritz.box> Co-authored-by: Caleb Roseland <caleb.roseland@mattermost.com> * MM-35932: changes strings due to re-packaging (#8170) * MM-35932: changes strings due to re-packaging * Apply suggestions from code review Co-authored-by: Katie Wiersgalla <39744472+wiersgallak@users.noreply.github.com> * Updates license page to reflect re-packaging * Fixes tests * Changes font-family on discovery pages * Fixes linting issues Co-authored-by: Katie Wiersgalla <39744472+wiersgallak@users.noreply.github.com> * Cypress/E2E Maintenance: Fix broken tests (#8542) * MM-37333 - fix info banner colors (#8539) Co-authored-by: Pablo Velez Vidal <pablo.velez@mattermost.com> * Pull unread thread counts for other teams on websocket reconnect (#8562) * MM-36977 Prevent unnecessary changes to emoji state (#8552) * Mm 37472 product switcher tip (#8544) * Add fifth tutorial tip * Add e2e test for tutorial tips * swap channel header bg and team sidebar bg colours (#8551) * swap channel header bg and team sidebar bg colours * snapshot updates * Webapp threads screen illustration updates (#8555) * Mm 37504 - add new invite people button to sidebar channel dropdown (#8563) * MM-37504 - add new invite button * fix snapshots * fix mobile styles Co-authored-by: Pablo Velez Vidal <pablo.velez@mattermost.com> * [MM-37716] Drop support for LHS specific bot icons (#8538) * [MM-36274] Catch all updates on Global Header with Compass (#8509) * added a very basic implementation of the compass-components package * moved compass-components for ProductSwitcher to separate component * added correct usage of element in Grid component and cleaned up comments * added generic type to the Grid component to fix typing issue * added return type to GlobalHeader component * added new compass-components release from npmjs * stuff happened * bumped compasss-component package version to 0.2.3 * some changes and version bump of compass-components * fix build, update compass components, theme tweak * revert compass components integration test code ... ... to the bare minimum, we will revisit in future pr's * update comment for temp theme implementation * move things around * Align items in global header * Switch to using @mattermost/compass-icons package # Conflicts: # package-lock.json # package.json * style overrides for legacy ui when GH is active * add structure, compartmentalize and tweak layout (#8512) * Add functionality to header buttons * fix lint errors * refactor search bar * Added tooltips * fix tooltips * fix tests * WIP - status dropdown * Move team menu * ix type error * Fix up product switcher menu * initial compass theme provider * adjust theme colours specifically for GH Will need to redo once compass components are used in other areas * hide GH using CSS instead of `isMobile` If a browser window starts narrow enough to be considered "mobile", the GH will be missing if the window is manually resized larger than "mobile" width. * wip: move rhs up next to channel header * add icons /w cds icon component * gh should be on top of the channel view * eslint fixes * add back search bar in mobile view * PR feedback - DEVS * Address final comments * Remove old search bar from global threads * bring back product tip and fix errors with master * update product branding * new `useIsModalOpen` hook that returns a ref ... for use in callbacks * Update components/global/product_switcher.tsx Revert to temp direct reference of icon to avoid issues, will re-implement in a future PR after connecting with product teams * fix lint issue * distinguish between icon glyph string & component Co-authored-by: Michel Engelen <jsnerdic@gmail.com> Co-authored-by: Dean Whillier <dean@whillier.com> Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MacBook-Pro.local> Co-authored-by: Dean Whillier <deanwhillier@users.noreply.github.com> Co-authored-by: Nevyana Angelova <nevyangelova@Nevyanas-MBP.fritz.box> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * [MM-37616] Self-managed: Update email template to new branding - Welcome and Verification email (#8533) * [MM-37616] - Update welcome and verify emails to new designs * add new dark logo * rm unused image * update logo email * removed the conditional rendering and instead added a StyledIcon that, when no icon string is provided, a `none` (placeholder/whitespace) icon (#8572) * Close products menu on switch (#8570) * Close products menu on switch * Fixing after merge * Being more specific about the click event handling * Adding todo entry * MM-37647 - modify branding svg images for cloud system console (#8560) * MM-37647 - modify branding svg images for cloud system console * check types in svgs * fix PR comments, remove unused images, add cloud trial svg image Co-authored-by: Pablo Velez Vidal <pablo.velez@mattermost.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * Update compass-icon `icon-file-document-outline` to match icon font rename (#8565) * update compass-icon name to match icon rename https://github.com/mattermost/compass-icons/commit/4b5b9f2d55fe2b1dd4c45b7ecf71fc0aff627e4b * snapshot updates * Add rest field support (#8153) * Add rest field support * Fix unneeded bang * Add tests * Fix help page images (#8431) * Update in-product help content: Messaging Basics Documentation task: https://mattermost.atlassian.net/browse/MM-36399 Updated: - In-product Help content on Messaging Basics * Update in-product help content: Composing Messages and Replies Documentation task: https://mattermost.atlassian.net/browse/MM-36399 Updated: - In-product Help content on Composing Messages and Replies * Update in-product help content: Mentioning Teammates Documentation task: https://mattermost.atlassian.net/browse/MM-36399 Updated: - In-product Help content on Mentioning Teammates * Update in-product help content: Formatting Messages Using Markdown Documentation task: https://mattermost.atlassian.net/browse/MM-36399 Updated: - In-product Help content on Formatting Messages Using Markdown * Update in-product help content: Attaching Files Documentation task: https://mattermost.atlassian.net/browse/MM-36399 Updated: - In-product Help content on Attaching Files * Update in-product help content: Executing Commands Documentation task: https://mattermost.atlassian.net/browse/MM-36399 Updated: - In-product Help content on Executing Commands * Update components/help/components/attaching.tsx * Update components/help/components/formatting.tsx Co-authored-by: Caleb Roseland <caleb.roseland@mattermost.com> * Update components/help/components/commands.tsx Co-authored-by: Caleb Roseland <caleb.roseland@mattermost.com> * Ran make targets * Linter fix * review updates * ran make target for updates * updated strings to en.json * Removed CRT references * Update components/help/components/attaching.tsx Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com> * Update i18n/en.json Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com> * Formatting & reviewer updates * Formatting fixes * formatting fixes Co-authored-by: Caleb Roseland <caleb.roseland@mattermost.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com> * [MM-36842] - Send email invites when clicking Next button in Onboarding (#8557) * [MM-36842] - Send email invites when clicking Next button in Onboarding * add e2e spec * update test number * [MM-37788] - Remove support email step in admin onboarding (#8556) * [MM-37788] - Remove support email step in admin onboarding * fix translations * [MM-37578] - Add setting for onboarding (#8528) * [MM-37578] - Add setting for onboarding * i18n-extract * update * feature: unify channel navigator in web and desktop app (#8574) * MM-37503 Channel sidebar header updates (#8569) * New channel sidebar header component for GH * make better use of styled-components * lint, test, snapshot updates * make sure there is a description * change help text for invite menu item * update snapshots * [MM-36758] Fix App filter and locations (#8452) * Fix filter and locations by considering the right types, and sending the location on commands. * Fix tests * Fix Lint Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * Mm 37049 cta cloud (#8553) * Send user into cloud upgrade modal on feature discovery page if they are in a cloud plan. * Hide start trial agreement wording in feature discovery for cloud users * Add e2e test for on prem feature discovery pages * Mm 37473 settings tip (#8578) * Add settings tip * Virtualized Thread Viewer (#8418) * MM-36698: ThreadViewer is now a virtualized list Added ThreadViewerVirtualized to handle: - displaying the thread in a virtualized list, - scrolling to {bottom/new-messages/permalinked replies} ThreadViewer has still the logic of fetching posts etc... * Fixes tests * Minor fixes * Delete unnecessary method * Fixes FloatingTimestamp * Call isMobile only when needed * Addressing review comments * Adds OnScrollArgs type to dynamic-virtualized-list * Removes unnecessary void return type * Scrolls to highlighted post when thread viewer is open * Minor fixes - highlighting a post after opening ThreadViewer - regain CreateComment focus after posting a comment - dot menu visible when only 2 replies * Fixes types * Fixes adding reaction in thread viewer shortcut By typing +:emoji: in the create comment in thread viewer you should add a reaction of 'emoji' to the last post. This commit fixes that. * Minor fixes - lint error - RHS top padding in thread list * Remove unneeded calculation of oldestPostId * Fixes linter * Addressing a bunch of review comments - blockFocus becomes focusOnMount - removed this.props.posts from thread_viewer - removed ephemeral post guard from thread - fixed scroll to bottom on new messages - removed unneeded memos * Fixes tests * Fixes scrolling to bottom issues * Fixes CreateComment re-mounting issue CreateComment was added in view with the last reply which resulted in -mounting when a new post was added, or the last post getting deleted. This commit introduces CreateComment as the last item on the list, and removes dependency on the last post. * Fixes scroll to bottom after highlighting a reply * Fixes linting issues * Fixes some e2e tests that broke * Fixes a11ly Due to a typo a11y was not enabled on ThreadViewer, this commit fixes that, and e2e that broke due to this, accessibility, issue. * Fixes tests Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * Filter forms and embedded bindings (#8249) * Filter forms and embedded bindings * Add tests and handle some command filters * Add command validation and improve and simplify fill bindings function * Filter invalid lookup items * Fix test * Get filteroptions to a helper function * Improve channel header icon filter * Fix tsc and address feedback Co-authored-by: Mattermod <mattermod@users.noreply.github.com> * [MM-31004] Highlight whole category bounds when holding a channel above a category name (#8490) * Fix category styling issue Fixes mattermost/mattermost-server#17736 * Remove unused classname and update snapshots * Fix e2e test broken by autoSortedCategory change * Add spacing beneath sidebar category new drop box * Fix linting issue * add CWS option to connect cloud server (#8580) * Translations update from Weblate (#8592) * Translated using Weblate (German) Currently translated at 100.0% (4802 of 4802 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4804 of 4804 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4801 of 4801 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4798 of 4798 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4798 of 4798 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Hungarian) Currently translated at 99.6% (4784 of 4801 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.5% (4773 of 4796 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.4% (4769 of 4796 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.3% (4766 of 4796 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.2% (4768 of 4802 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Transl…

mm-cloud-bot added the release-note-none label Jul 28, 2021

pvev requested review from marianunez and AGMETEOR July 28, 2021 20:41

pvev added the 2: Dev Review Requires review by a core commiter label Jul 28, 2021

marianunez added 1: UX Review Requires review by a UX Designer 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jul 29, 2021

marianunez previously requested changes Jul 29, 2021

View reviewed changes

marianunez requested review from nickmisasi and matthewbirtch July 29, 2021 13:12

marianunez requested review from marianunez and removed request for marianunez July 29, 2021 15:02

MM-37299 - invite members ab testing

1cad17a

pvev force-pushed the MM-37299-invite-members-ab-testing branch from 9b9a8c0 to 1cad17a Compare July 30, 2021 10:32

AGMETEOR approved these changes Jul 30, 2021

View reviewed changes

pvev added Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal labels Jul 30, 2021

nickmisasi added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jul 30, 2021

mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jul 30, 2021

nickmisasi added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jul 30, 2021

pvev requested a review from stevemudie July 30, 2021 16:01

stevemudie approved these changes Jul 30, 2021

View reviewed changes

stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Jul 30, 2021

Merge branch 'master' into MM-37299-invite-members-ab-testing

ecb7bde

pvev added 2 commits July 30, 2021 20:54

add suggested UX changes

a9ad706

fix linter

4c38f18

matthewbirtch approved these changes Jul 30, 2021

View reviewed changes

final changes to UX

c6f93ae

matthewbirtch removed the 1: UX Review Requires review by a UX Designer label Jul 30, 2021

pvev added 2 commits July 31, 2021 12:19

fix linter

eac4746

fix snapshot

54e0e81

pvev removed the 2: Dev Review Requires review by a core commiter label Jul 31, 2021

pvev merged commit b3f2bc2 into master Jul 31, 2021

pvev deleted the MM-37299-invite-members-ab-testing branch July 31, 2021 13:55

mattermod removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jul 31, 2021

amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Aug 3, 2021

stevemudie added the Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal label Aug 26, 2021

neallred removed the Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal label Jan 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MM-37299 - invite members ab testing #8491

MM-37299 - invite members ab testing #8491

pvev commented Jul 28, 2021

marianunez left a comment

marianunez Jul 29, 2021

marianunez Jul 29, 2021

marianunez Jul 29, 2021

marianunez Jul 29, 2021

marianunez Jul 29, 2021

matthewbirtch commented Jul 29, 2021

pvev commented Jul 29, 2021

AGMETEOR left a comment

pvev commented Jul 30, 2021

stevemudie left a comment

pvev commented Jul 30, 2021

matthewbirtch commented Jul 30, 2021

matthewbirtch left a comment

mm-cloud-bot commented Jul 31, 2021

mm-cloud-bot commented Jul 31, 2021

mm-cloud-bot commented Aug 26, 2021

		{addChannelDropdown}
		<InviteMembersButton buttonType='icon-button'/>

MM-37299 - invite members ab testing #8491

MM-37299 - invite members ab testing #8491

Conversation

pvev commented Jul 28, 2021

Summary

Ticket Link

Related Pull Requests

Screenshots

Release Note

marianunez left a comment

Choose a reason for hiding this comment

marianunez Jul 29, 2021

Choose a reason for hiding this comment

marianunez Jul 29, 2021

Choose a reason for hiding this comment

marianunez Jul 29, 2021

Choose a reason for hiding this comment

marianunez Jul 29, 2021

Choose a reason for hiding this comment

marianunez Jul 29, 2021

Choose a reason for hiding this comment

matthewbirtch commented Jul 29, 2021

pvev commented Jul 29, 2021

AGMETEOR left a comment

Choose a reason for hiding this comment

pvev commented Jul 30, 2021

stevemudie left a comment

Choose a reason for hiding this comment

pvev commented Jul 30, 2021

matthewbirtch commented Jul 30, 2021

User Icon Option

Sticky Button Option

LHS button version

matthewbirtch left a comment

Choose a reason for hiding this comment

mm-cloud-bot commented Jul 31, 2021

mm-cloud-bot commented Jul 31, 2021

mm-cloud-bot commented Aug 26, 2021