This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Use consistent image #384
Merged
Use consistent image #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Breaking build step is known to the introducer: https://github.com/mattermost/mmctl/commits/master |
streamer45
reviewed
Aug 24, 2021
| @@ -25,7 +25,7 @@ commands: | |||
| parameters: | |||
| version: | |||
| type: string | |||
| default: 1.31.0 | |||
| default: 1.42.0 | |||
There was a problem hiding this comment.
Is this needed or just updating while we are here?
There was a problem hiding this comment.
Just updating while we are here.
There was a problem hiding this comment.
Alright, as long as it doesn't cause new errors we should be good :)
There was a problem hiding this comment.
You are right, might need a cache key bump.
streamer45
approved these changes
Aug 24, 2021
metanerd
added a commit
that referenced
this pull request
Aug 24, 2021
* Use consistent and newer images. * Bump cache key
metanerd
added a commit
that referenced
this pull request
Aug 24, 2021
* Lock CI from /release-5.38 (#369) Co-authored-by: Mmbot <mmbot@mattermost> * [Build] Support go 1.17 (#381) * Build on 1.17.0 for #381 (#383) * Build on 1.17.0 for #381 * Use consistent image (#384) * Use consistent and newer images. * Bump cache key Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Mmbot <mmbot@mattermost> Co-authored-by: Roopak Venkatakrishnan <roopak.v@gmail.com>
metanerd
added a commit
that referenced
this pull request
Aug 26, 2021
metanerd
added a commit
that referenced
this pull request
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link