-
Notifications
You must be signed in to change notification settings - Fork 326
adapted the sqlite driver for v3 (#165) #238
Conversation
1 similar comment
Hey @mattes, I desperately need this functionality. Could you please merge this PR in? Thank you! 😄 |
can you add the build file (ex https://github.com/mattes/migrate/blob/master/cli/build_ql.go) for this driver, please? thanks for the PR! will merge after this! |
1 similar comment
@mattes done, that should work now too. (I had completely overlooked it as I only use the functionality in Go itself, not the command-line version) |
merged! thank you so much! |
@maxvw I see some errors: https://travis-ci.org/mattes/migrate/jobs/239468284#L1513 Any idea what's going on? |
@mattes on first inspection this seems to be due to the fact that Someone mentioning a similar issue: mattn/go-sqlite3#384 But if it makes cross-compiling more challenging people will also have this issue in their own project if they include the |
ok, thanks! I just enabled CGO based on: mattn/go-sqlite3@98981b4 |
@mattes alright nice, hopefully that solves it! |
- Removed sqlite3 support from binaries - It was never working anyways: mattes/migrate#244 - Don't use cgo as is requires a cross-compiler to build for other platforms - cgo was originally added for this reason: mattes/migrate#238 (comment)
When I discovered your project I thought it was perfect, just what I needed! However soon after that I discovered the latest version lacked SQLite support. So I've copied the Ql driver and adapted it to work for SQLite, I think I've covered everything but if I forgot something please let me know!
I wasn't sure which naming convention to use, in the previous version I see it was called
sqlite3
but in the new version there was a directory reserved calledsqlite
. I've opted for thesqlite3
naming as the actual driver is also calledsqlite3
so I think that made more sense.