Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for LocalAuthLists #213

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Unit tests for LocalAuthLists #213

merged 3 commits into from
Oct 15, 2023

Conversation

matth-x
Copy link
Owner

@matth-x matth-x commented Oct 15, 2023

Adding unit tests for the Authorization module. The Authorization module was restructured a bit for better testability. While creating the unit tests, the following defects were found and fixed:

  • The configuration ConnectionTimeOut limited the duration of the overall Preparation phase. Now it's restricted to only abort the transaction process if the EVSE is not plugged early enough.
  • LocalPreAuthorize was disabled too when LocalAuthorizeOffline was false
  • SendLocalList with updateType Full also expected an incrementing listVersion. This only applies to Differential updates now

@matth-x matth-x merged commit eeb656b into develop Oct 15, 2023
5 checks passed
@matth-x matth-x deleted the feature/localauth-test branch October 15, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant