Update w2w.py #21
Merged
Update w2w.py #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculation of distance using spherical law of cosines, not directly degrees
jkittner
reviewed
Dec 13, 2021
Select AT LEAST the number of pixels indicated by the user. This may produce a larger number of pixels selected if the farthest points of the selection are at the same distance.
Added test for distance calculation
jkittner
force-pushed
the
Coordinate_distance
branch
from
617d785 to
e97bdee
Compare
jkittner
approved these changes
Dec 13, 2021
jkittner
force-pushed
the
Coordinate_distance
branch
from
effc3b8 to
e97bdee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculation of distance using spherical law of cosines, instead of using coordinates directly. This was a good approximation near the equator, but failed for our purposes as we move to the poles.