-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plot W2W results #78
plot W2W results #78
Conversation
Added script and image to visualize before and after w2w. Added information to README on outputs and this figure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look at this!
The image as a png
does not work well with dark mode:
we can either create two plots (one for light, the other for dark mode) or just make it a jpg, leaving out the transparent background.
See also: https://github.blog/changelog/2021-11-24-specify-theme-context-for-images-in-markdown/
For the plot script I am wondering if we can do this in a loop, to save on copy pasta code. I'll have a look at that and maybe come up with a suggestion.
I tried merging the options that are applied to each plot a bit. Unfortunately I wasn't able to run the code, because I can't install Maybe you can have one last look and check if the notebook runs, then I can clean up the commits a little and it's good to go. Thanks for your great work on this 👍 |
I tried to run it but I get the following error: AttributeError: 'LineCollection' object has no property 'right_labels' when saving the figure. For some reason If I try gl1.right_labels=False. It works fine. The same for |
huh, that's annoying - I changed it back and was also able to get things up and running using docker. So this should all work now! I'll have one last look myself, please also do so. Then I think it's ready and I can squash and merge it. |
Tested. Good to go! 🟢 |
Co-authored-by: Jonas Kittner <54631600+theendlessriver13@users.noreply.github.com>
75f12d5
to
f69b473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added script and image to visualize before and after w2w.
Added information to README on outputs and this figure.