Fix FAKE Chinese text bug

[nosami]

See
fsprojects/FAKE#1196,
fsprojects/FAKE#1212,
fsprojects/FAKE#1213 &
fsprojects/FAKE#1194

Not sure of the ramifications of this change, but this fixes the
encoding issues in FAKE on Mono for me.

l.Head.Encoding was
System.IO.StringWriter(new System.Text.StringBuilder()).Encoding
which evaluates to utf-16 on both Windows and on Mono
/cc:@forki

[forki]

Wow

[nosami]

OK. I might have been a little premature with this fix.
The only way I can guarantee that there is no Chinese output in FAKE is to add System.Console.OutputEncoding <- System.Text.Encoding.UTF8 to the top of build.fsx. Not sure why.

[nosami]

Even this doesn't work inside FAKE :-

session.EvalInteraction "System.Console.OutputEncoding <- System.Text.Encoding.UTF8"
session.EvalScript pathToBuildFsx

but adding the same line to build.fsx manually does work, which makes me think the issue is in Yaaf somewhere.

[nosami]

False alarm - it does work. I was invoking ./build.sh which was using the wrong FAKE.exe

[forki]

I'm temporarily pointing FAKE's paket.dependencies to this fork. Thanks for investigating

[matthid]

I don't really understand how this fixes the problem. How does it even matter what the wrapper class returns? This feels wrong. At the very least there should be a comment explaining this.

[matthid]

I'm using Console.SetOut that might be somehow related...

[matthid]

Merged as I don't know how this can have any effect. Documentation says this property is only to help XML writers: https://msdn.microsoft.com/en-us/library/system.io.textwriter.encoding%28v=vs.110%29.aspx?f=255&MSPPError=-2147217396

[matthid]

Please test again https://www.nuget.org/packages/Yaaf.FSharp.Scripting/1.7.1 and report back if it fixed the problem.

Thanks for the analysis and the PR.

[nosami]

Thanks for merging. I don't understand why this fix works either, but it does!

[forki]

it worked! fsprojects/Paket#1948

Thanks so much!