-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure with musl 1.2.4 #1164
Comments
This version includes support for Go 1.20 (specifically 1.20.5), and a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3[1]. This also updates the package license; the project was relicensed in 3.13.0[2]. [1]: mattn/go-sqlite3#1164 [2]: ooni/probe-cli#446 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
This version includes support for Go 1.20 (specifically 1.20.5), and a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3[1]. This also updates the package license; the project was relicensed in 3.13.0[2]. [1]: mattn/go-sqlite3#1164 [2]: ooni/probe-cli#446 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
This version includes support for Go 1.20 (specifically 1.20.5). This also: * Adds a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3[1] * Sets GO_PKG_BUILD_PKG to build the main binary (ooniprobe) only * Updates the package license; the project was relicensed in 3.13.0[2] [1]: mattn/go-sqlite3#1164 [2]: ooni/probe-cli#446 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
Not sure how come this isn't extremely urgent to users out there but the #1177 save me. replace github.com/mattn/go-sqlite3 => github.com/leso-kn/go-sqlite3 v0.0.0-20230710125852-03158dc838ed |
This version includes support for Go 1.20 (specifically 1.20.5). This also: * Adds a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3[1] * Sets GO_PKG_BUILD_PKG to build the main binary (ooniprobe) only * Updates the package license; the project was relicensed in 3.13.0[2] [1]: mattn/go-sqlite3#1164 [2]: ooni/probe-cli#446 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
you can use |
This version includes support for Go 1.20 (specifically 1.20.5). This also: * Adds a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3[1] * Sets GO_PKG_BUILD_PKG to build the main binary (ooniprobe) only * Updates the package license; the project was relicensed in 3.13.0[2] [1]: mattn/go-sqlite3#1164 [2]: ooni/probe-cli#446 Signed-off-by: Jeffery To <jeffery.to@gmail.com> (cherry picked from commit dc7382e)
This version includes support for Go 1.20 (specifically 1.20.5). This also: * Adds a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3[1] * Sets GO_PKG_BUILD_PKG to build the main binary (ooniprobe) only * Updates the package license; the project was relicensed in 3.13.0[2] [1]: mattn/go-sqlite3#1164 [2]: ooni/probe-cli#446 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
This version includes support for Go 1.20 (specifically 1.20.5). This also: * Adds a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3[1] * Sets GO_PKG_BUILD_PKG to build the main binary (ooniprobe) only * Updates the package license; the project was relicensed in 3.13.0[2] [1]: mattn/go-sqlite3#1164 [2]: ooni/probe-cli#446 Signed-off-by: Jeffery To <jeffery.to@gmail.com>
See-also: mattn/go-sqlite3#1164 Closes: 912311 Signed-off-by: Alfred Persson Forsberg <cat@catcream.org>
[sam: The macro is not ideal at all but patching Go isn't exactly ideal itself. Besides, this was arleady in the ebuild, but ignored b/c Go doesn't yet in Gentoo respect CFLAGS et. al, although should soon.] See-also: mattn/go-sqlite3#1164 Closes: https://bugs.gentoo.org/912311 Signed-off-by: Alfred Persson Forsberg <cat@catcream.org> Closes: #33863 Signed-off-by: Sam James <sam@gentoo.org>
Switching to Fedora containers due to an updated musl in alpine causing build errors in Go bindings to sqlite, see: mattn/go-sqlite3#1164
Switching to Fedora containers due to an updated musl in alpine causing build errors in Go bindings to sqlite, see: mattn/go-sqlite3#1164
Switching to Fedora containers due to an updated musl in alpine causing build errors in Go bindings to sqlite, see: mattn/go-sqlite3#1164
This is now broken in latest As a temporary workaround, it's possible to downgrade base go image to \cc @mattn |
I agree with @r10r, upgrading to 1.14.19 fixes the issue. |
Update all dependencies. Update github.com/mattn/go-sqlite3 to v1.14.19 for fixing mattn/go-sqlite3#1164. Switch to alpine 1.19.
This fails with |
@martinrode which version of this library are you using? |
The latest released version v1.14.16 |
@martinrode the latest release is v1.14.22 |
Closing because this issue is resolved in v1.14.19. |
It's fine. Works with TAG checkout v1.14.22. I checked Github Releases only and there the latest is .16. |
Fixes build failure on musl[1] [1]: mattn/go-sqlite3#1164 Signed-off-by: Joe Groocock <me@frebib.net>
sha256sum in busybox doesn't support --check. go-sqlite3 fails to build: mattn/go-sqlite3#1164
* fix: change isolate daemon command in scripts/start_container.sh * feat: Remove isolate in docker/Dockerfile * chore: update go-sqlite3 to fix musl build mattn/go-sqlite3#1164 * feat: Dockerfile for gcc-only * feat: accept arbitrary command for isolate daemon * feat(isolate): print logs real-time and add Stop() * chore: update golangci-lint to make tests passable
OpenWrt updated musl to 1.2.4 and we are seeing this build failure with ooni/probe-cli (which uses go-sqlite3):
(This is from a PR for the current version of probe-cli which uses 1.14.16; we are also seeing very similar errors when building an older version of probe-cli which uses 1.14.15.)
This is because in musl 1.2.4, LFS64 interfaces were marked as deprecated (release notes, commit).
Perhaps
HAVE_PREAD
/HAVE_PWRITE
can be set instead ofHAVE_PREAD64
/HAVE_PWRITE64
in sqlite3.go?The text was updated successfully, but these errors were encountered: