-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for sqlite_math_functions tag #1059
Conversation
6999866
to
6acc037
Compare
6acc037
to
fe6ab89
Compare
sqlite3_opt_math_functions_test.go
Outdated
} | ||
|
||
for _, query := range queries { | ||
if _, err := db.Query(query); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now you are dropping the Rows
object. That means you are only checking for an error from sqlite3_prepare_v2
and not sqlite3_step
. For completeness we should check both, which is why QueryRow
would be preferable.
var result float64
if err := db.QueryRow(query).Scan(&result); err != nil {
t.Errorf("invoking math function query %q: %v", query, err)
}
// For the purposes of this test, we don't care about the output, just that the query succeeded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see... thanks for the review :)
Seems okay to me. |
Codecov ReportBase: 46.09% // Head: 46.09% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1059 +/- ##
=======================================
Coverage 46.09% 46.09%
=======================================
Files 11 11
Lines 1499 1499
=======================================
Hits 691 691
Misses 669 669
Partials 139 139 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Failure is due to unrelated issue introduced in #1085. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/mattn/go-sqlite3](https://github.com/mattn/go-sqlite3) | require | patch | `v1.14.15` -> `v1.14.16` | --- ### Release Notes <details> <summary>mattn/go-sqlite3</summary> ### [`v1.14.16`](https://github.com/mattn/go-sqlite3/releases/tag/v1.14.16) [Compare Source](https://github.com/mattn/go-sqlite3/compare/v1.14.15...v1.14.16) #### What's Changed - Add build tag to enable OSTRACE() logging by [@​benbjohnson](https://github.com/benbjohnson) in [https://github.com/mattn/go-sqlite3/pull/1067](https://github.com/mattn/go-sqlite3/pull/1067) - TestQueryer: actually check Rows returned by [@​ohwgiles](https://github.com/ohwgiles) in [https://github.com/mattn/go-sqlite3/pull/1062](https://github.com/mattn/go-sqlite3/pull/1062) - Update README to fix reference URL by [@​shibukawa](https://github.com/shibukawa) in [https://github.com/mattn/go-sqlite3/pull/1082](https://github.com/mattn/go-sqlite3/pull/1082) - Fix test queryer test by [@​joshbuddy](https://github.com/joshbuddy) in [https://github.com/mattn/go-sqlite3/pull/1079](https://github.com/mattn/go-sqlite3/pull/1079) - Rollback on constraint failure by [@​joshbuddy](https://github.com/joshbuddy) in [https://github.com/mattn/go-sqlite3/pull/1071](https://github.com/mattn/go-sqlite3/pull/1071) - Fix "ennviroment" by [@​RewardedIvan](https://github.com/RewardedIvan) in [https://github.com/mattn/go-sqlite3/pull/1077](https://github.com/mattn/go-sqlite3/pull/1077) - こんにちわ is wrong Japanse, Correct word is こんにちは by [@​KiYugadgeter](https://github.com/KiYugadgeter) in [https://github.com/mattn/go-sqlite3/pull/1085](https://github.com/mattn/go-sqlite3/pull/1085) - Add test for sqlite_math_functions tag by [@​lggruspe](https://github.com/lggruspe) in [https://github.com/mattn/go-sqlite3/pull/1059](https://github.com/mattn/go-sqlite3/pull/1059) - remove unuseful ldflags for windows platform. by [@​kkqy](https://github.com/kkqy) in [https://github.com/mattn/go-sqlite3/pull/1084](https://github.com/mattn/go-sqlite3/pull/1084) - Cross Compiling for Mac OS via `musl-cross` by [@​jodosha](https://github.com/jodosha) in [https://github.com/mattn/go-sqlite3/pull/1090](https://github.com/mattn/go-sqlite3/pull/1090) - Update README.md to include vtable feature by [@​dvas0004](https://github.com/dvas0004) in [https://github.com/mattn/go-sqlite3/pull/1100](https://github.com/mattn/go-sqlite3/pull/1100) - Updating vtable example, "BestIndex" method by [@​dvas0004](https://github.com/dvas0004) in [https://github.com/mattn/go-sqlite3/pull/1099](https://github.com/mattn/go-sqlite3/pull/1099) - Update amalgamation code by [@​mattn](https://github.com/mattn) in [https://github.com/mattn/go-sqlite3/pull/1104](https://github.com/mattn/go-sqlite3/pull/1104) #### New Contributors - [@​ohwgiles](https://github.com/ohwgiles) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1062](https://github.com/mattn/go-sqlite3/pull/1062) - [@​shibukawa](https://github.com/shibukawa) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1082](https://github.com/mattn/go-sqlite3/pull/1082) - [@​joshbuddy](https://github.com/joshbuddy) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1079](https://github.com/mattn/go-sqlite3/pull/1079) - [@​RewardedIvan](https://github.com/RewardedIvan) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1077](https://github.com/mattn/go-sqlite3/pull/1077) - [@​KiYugadgeter](https://github.com/KiYugadgeter) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1085](https://github.com/mattn/go-sqlite3/pull/1085) - [@​lggruspe](https://github.com/lggruspe) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1059](https://github.com/mattn/go-sqlite3/pull/1059) - [@​kkqy](https://github.com/kkqy) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1084](https://github.com/mattn/go-sqlite3/pull/1084) - [@​jodosha](https://github.com/jodosha) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1090](https://github.com/mattn/go-sqlite3/pull/1090) - [@​dvas0004](https://github.com/dvas0004) made their first contribution in [https://github.com/mattn/go-sqlite3/pull/1100](https://github.com/mattn/go-sqlite3/pull/1100) **Full Changelog**: mattn/go-sqlite3@v1.14.15...v1.14.16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/mergestat/mergestat). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xLjUiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xLjUifQ==-->
Hello, this is a continuation of #1037, which fixes #990.
Changes
@rittneje @nkt-dk