Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "database is locked" documentation #827

Closed
wants to merge 1 commit into from
Closed

Update "database is locked" documentation #827

wants to merge 1 commit into from

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Jul 4, 2020

This explains a bit more what is going on, removes the recommendation to
set cache to shared (which is considered deprecated), and mentions using
the WAL.

This explains a bit more what is going on, removes the recommendation to
set cache to shared (which is considered deprecated), and mentions using
the WAL.

Add to DSN: `cache=shared`
One way to fix this is to ensure your program limits the number of writers
to 1, for example by using `sync.Mutex` (it's fine to be have multiple
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having multiple writers is actually not itself a problem. However, what can cause an issue even with write-ahead logging is if a connection tries to write after reading within a transaction.

tx := database.Begin()
...
tx.QueryRow(`SELECT ID FROM Foo WHERE ...`)
...
tx.Exec(`UPDATE Foo ...`)
...

The problem here is that if the database gets modified between the SELECT and the UPDATE by another connection, there is no way for SQLite to properly retain the "isolation" property of ACID. This is because the interim modification may have changed the very data you read out. This issue can be avoided by always using immediate locking behavior (i.e., BEGIN IMMEDIATE) for any transactions that may ultimately write to the database. (It of course is also avoided by throttling the connection pool to one, provided that no other applications will also be writing to the same database.)

@coveralls
Copy link

coveralls commented Jul 4, 2020

Coverage Status

Coverage remained the same at 53.404% when pulling 6e600f0 on zgoat:lock into aa77c03 on mattn:master.

```

Second please set the database connections of the SQL package to 1.

To guarantee only one connection is being run at the same time yoi can set
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To guarantee only one connection is being run at the same time yoi can set
To guarantee only one connection is being run at the same time, you can set

@tshepang
Copy link

tshepang commented May 4, 2021

As for me, problem was fixed by closing Rows, as shown on https://stackoverflow.com/a/32483180/321731.

@DmitriyMV
Copy link

Kindly ping @arp242

@arp242 arp242 closed this Jan 10, 2022
@arp242 arp242 deleted the lock branch January 10, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants