-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arbitrary messaging from external loaders #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reference external dereferencing tests
mattpolzin
force-pushed
the
add-external-loader-message-system
branch
from
April 25, 2024 14:02
fdc88f0
to
76898f6
Compare
mattpolzin
force-pushed
the
add-external-loader-message-system
branch
3 times, most recently
from
April 26, 2024 03:29
1a56c43
to
af2909f
Compare
mattpolzin
force-pushed
the
add-external-loader-message-system
branch
from
April 26, 2024 03:36
af2909f
to
a3d852c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea with this change is to allow an
ExternalLoader
to pass messages back to whatever is actually kicking dereferencing off. These messages can look like anything that happens to be useful.Breaking Changes
ExternalLoader
protocol'sload()
function needs to return an array of "messages" now. If you don't need this parameter, you can set the type of the message toVoid
and always return an empty array. The new return is there to facilitate you passing information back to yourself from theload()
function.