Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary messaging from external loaders #374

Merged
merged 14 commits into from
Apr 26, 2024

Conversation

mattpolzin
Copy link
Owner

@mattpolzin mattpolzin commented Apr 24, 2024

The idea with this change is to allow an ExternalLoader to pass messages back to whatever is actually kicking dereferencing off. These messages can look like anything that happens to be useful.

Breaking Changes

  • The ExternalLoader protocol's load() function needs to return an array of "messages" now. If you don't need this parameter, you can set the type of the message to Void and always return an empty array. The new return is there to facilitate you passing information back to yourself from the load() function.

@mattpolzin mattpolzin force-pushed the add-external-loader-message-system branch from fdc88f0 to 76898f6 Compare April 25, 2024 14:02
@mattpolzin mattpolzin force-pushed the add-external-loader-message-system branch 3 times, most recently from 1a56c43 to af2909f Compare April 26, 2024 03:29
@mattpolzin mattpolzin force-pushed the add-external-loader-message-system branch from af2909f to a3d852c Compare April 26, 2024 03:36
@mattpolzin mattpolzin marked this pull request as ready for review April 26, 2024 03:43
@mattpolzin mattpolzin merged commit a0513e6 into release/4_0 Apr 26, 2024
16 checks passed
@mattpolzin mattpolzin deleted the add-external-loader-message-system branch April 26, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant