Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to async based api #61

Merged
merged 2 commits into from
Feb 22, 2021
Merged

feat: migrate to async based api #61

merged 2 commits into from
Feb 22, 2021

Conversation

tplooker
Copy link
Member

@tplooker tplooker commented Nov 26, 2020 •
edited
Loading

Description

Migrates the API to be async (promise) based

Also fixes #60 by using WebAssembly.instantiate

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Does this PR introduce a breaking change?

  • Yes
  • No

All API's will now return a promise wrapped result rather than the result directly.

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@tplooker tplooker mentioned this pull request Jan 28, 2021
Closed
@tplooker tplooker marked this pull request as ready for review February 22, 2021 09:10
kdenhartog
kdenhartog approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a few nitpicks and questions in there, but it looks good. Feel free to merge if you don't want to change anything.

src/bbs_plus.rs Show resolved Hide resolved
src/js/wasm_helper.js Show resolved Hide resolved
tests/bbsSignature/sign.bbsSignature.spec.ts Show resolved Hide resolved
tests/bbsSignature/verify.bbsSignature.spec.ts Show resolved Hide resolved
tests/bbsSignature/verify.bbsSignature.spec.ts Show resolved Hide resolved
tests/bbs_plus.rs Show resolved Hide resolved
@tplooker tplooker merged commit 5dbd924 into master Feb 22, 2021
@tplooker tplooker deleted the tl/async-api branch February 22, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdenhartog kdenhartog kdenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASM invocation in chromium browsers rolling back to ASM.js
2 participants
@tplooker @kdenhartog