Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you be interested in moban project? #74

Closed
chfw opened this issue Mar 8, 2019 · 3 comments
Closed

Would you be interested in moban project? #74

chfw opened this issue Mar 8, 2019 · 3 comments

Comments

@chfw
Copy link

chfw commented Mar 8, 2019

Dear Matt:

moban dev team noticed your effort to bring jinja to command line interface. We are doing the same thing as you are doing. Would you like to check us out? https://moban.readthedocs.io/en/latest/

Thanks

@mattrobenolt
Copy link
Owner

What's the question? This works for my needs and apparently 200 others. Why not contribute back here? Was there something inherently wrong with my version? I don't mind, but I don't see value in switching to something else.

@chfw
Copy link
Author

chfw commented Mar 8, 2019

I admire the fact that 200+ users love your project as we are all open source developers. And I respect your time and effort in serving your users for more than 6 years. But I look forward to what even more to come if we should join force and work together towards the same goal.

It is a good question why not contribute back to your project? I do not think it is ever intentional. We all started with a different use case under a different perspective in different time frame for a different goal. At one point, one open source veteran @jayvdb pointed me towards your repo. Please understand that I am not cleverer than a foo.

Nothing is wrong with your version. Please let me share some of moban features that match some of your open issues:

  1. allow user have custom jinja2 filters, tests, and globals , like Ansible for Implement a way to load custom filters similar to how Ansible does #66, Add jinja2Global global variable. #44
  2. output to a specified file for [Feature Request] Specify output file #56
  3. works on py3.5, 3.6, 3.7, 3.8, even on pypy2 for Failure on python3.5 #53
  4. bring environment variables inside template for Add support for environment variables as a source without code modification #69
  5. allow user defined template dirs for Relative paths when including templates? #37
  6. maybe makefile could be replaced by a yaml file for Very weird bug: jinja2-cli undefined variables when using python in stdin #72

I am sorry that I jumped in to your repo and say hello in this manner. My intention is to seek friendship and potential joint-force. If you checkout our documentation, you are more than welcome to point out what moban cannot do but jinja2-cli can. We have a gitter channel if you would like to chat with moban dev team.

@mattrobenolt
Copy link
Owner

Nah, that's fine. I'm just not sure what you're asking of me. Feel free to just steal code from here if you want. I write tools for me, so I will continue to develop this and use it.

Most of the issues you've pointed to aren't relevant and have already been dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants