-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add low-setup usage #146
Conversation
Working on writing tests and updating the proper documentation. |
270f9c2
to
b32bc8a
Compare
Codecov Report
@@ Coverage Diff @@
## dev #146 +/- ##
=========================================
- Coverage 98.33% 97.7% -0.63%
=========================================
Files 39 40 +1
Lines 1857 1918 +61
=========================================
+ Hits 1826 1874 +48
- Misses 31 44 +13
Continue to review full report at Codecov.
|
b32bc8a
to
f79d32b
Compare
An update on the documentation regarding this new usage would be helpful. |
97f01a8
to
baa4aaa
Compare
baa4aaa
to
07cb156
Compare
With a rule
However ... Traceback (most recent call last):
File "/home/jayvdb/.local/bin/moban", line 11, in <module>
load_entry_point('moban', 'console_scripts', 'moban')()
File "/home/jayvdb/projects/moban/moban/moban/main.py", line 36, in main
count = handle_moban_file(moban_file, options)
File "/home/jayvdb/projects/moban/moban/moban/main.py", line 121, in handle_moban_file
mobanfile.handle_moban_file_v1(moban_file_configurations, options)
File "/home/jayvdb/projects/moban/moban/moban/mobanfile.py", line 40, in handle_moban_file_v1
target = extract_target(command_line_options)
File "/home/jayvdb/projects/moban/moban/moban/mobanfile.py", line 149, in extract_target
"Please specify a output file name for %s." % template
Exception: Please specify a output file name for foo/bar.py.jj2. And And all of the above then process the |
07cb156
to
a4e9dc8
Compare
This adds the ability to use moban in an ad-hoc manner without a config file. This also adds environment variables as a fallback data source if the default/specified data files do not exist. Closes moremoban#133
a4e9dc8
to
d9e98b8
Compare
However, I think the code refactoring could be done in a separate PR. Letting this PR pending so long is not good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code refactoring is required before releasing. Otherwise, functionalities are agreed.
Related to moremoban#146
Related to moremoban#146
This adds the ability to use moban in an ad-hoc manner
without a config file. This also adds environment variables
as a fallback data source if the default/specified data files
do not exist.
Closes #133
Before raising the PR, here is a check list:
5.1) can someone else understand your changes without your explanation?
6.1) do you have the feeling of achievement?