Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with missing package and update documentation. #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanpcmcquen
Copy link

This closes #10, #11, and #12 at least. Maybe more?

Signed-off-by: Ryan P. C. McQuen ryanpcmcquen@member.fsf.org

Signed-off-by: Ryan P. C. McQuen <ryanpcmcquen@member.fsf.org>
@Kizuna-Meraki
Copy link

Kizuna-Meraki commented May 26, 2020

I downloaded and installed Ryan's modifications and can confirm they work fine and definitely fix Issue#15, which I opened up three days ago.

DETAILS

  • 2017 iMac running
  • macOS Catalina 10.15.4 with
  • Python 3.7 installed

@501st-alpha1
Copy link

Since Signal now requires SQLCipher 4 (see my comment on #13 for details), it would probably be better to just delete the lines in scab.py, rather than comment them out. The lines will still be in the Git history if someone needs to reference them, so there's no need to leave them commented-out in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: pysqlcipher3.dbapi2.DatabaseError: file is not a database
3 participants