Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a config for a homeserver with animated media support #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

salixor
Copy link
Contributor

@salixor salixor commented Sep 12, 2023

This provides a way to display animated media in the widget, by using a homeserver with a media repo which supports them.

It makes it possible to use one homeserver (which doesn't support such a media repo) for most of the thumbnails, and use one with support for the few animated media.

This is an optional config, which defaults to homeserver_url.

@tulir
Copy link
Member

tulir commented Sep 12, 2023

Why not just use the same one with proper thumbnailing support? 🤔

Could also not thumbnail for animated stickers, that way it works with all media repos

@LuckyTurtleDev
Copy link

Why not just use the same one with proper thumbnailing support?

This would be to easy.

@salixor
Copy link
Contributor Author

salixor commented Sep 12, 2023

The reasoning was to provide a way for people with no control over their homeserver (which may or not support such media repos) to have some configuration available to them.

Let's say their current HS supports animated thumbnails (it's nice to have them in the picker IMO) - but their HS is struggling. They switch to another one for thumbnails, but this one no longer supports animated thumbnails. They may want to display their stickers, and let the animated one load when they can.

I understand the best is to use the same HS in both cases, but having some additional configuration doesn't feel too irrational ! I'd understand if you don't want to merge it, I proposed this PR just in case it could be interesting for upstream as well o/

@YourSandwich
Copy link

Hello @salixor thank you for providing this code, I am interested in implementing this into my home server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants