Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now getting the line-numbers right #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Now getting the line-numbers right #139

wants to merge 1 commit into from

Conversation

mauro3
Copy link
Owner

@mauro3 mauro3 commented Feb 25, 2021

Fixes #137

Notes:

  • adds MacroTools as a dep
  • NamedTuples don't have line numbers. Thus none here either.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #139 (d5b0db3) into master (ecbf8df) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   93.66%   93.77%   +0.11%     
==========================================
  Files           1        1              
  Lines         284      273      -11     
==========================================
- Hits          266      256      -10     
+ Misses         18       17       -1     
Impacted Files Coverage Δ
src/Parameters.jl 93.77% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbf8df...d5b0db3. Read the comment docs.

@mauro3
Copy link
Owner Author

mauro3 commented Mar 23, 2021

Probably should merge this. A bit hesitant because of the new MacroTools dep...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line information is wrong for structs using Parameters.jl
1 participant