Crashes due to missing LocationService null checks

[ivosabev]

There are multiple errors reported where the LocationService is referenced when it was killed by the system and its value is null.

Examples:
#232
#201

It seems that it is due calling methods on mService without a null check in common/src/main/java/com/marianhello/bgloc/BackgroundGeolocationFacade

Examples:

public void switchMode(final int mode) {
    synchronized (mLock) {
        mService.executeProviderCommand(LocationProvider.CMD_SWITCH_MODE, mode);
    }
}

public void sendCommand(final int commandId) {
    synchronized (mLock) {
        mService.executeProviderCommand(commandId, 0);
    }
}

In general in Android you can never expect the Service to be running, since the system kills them at a whim. I think the least to do is add a null check. I can submit a pull request, but wanted to check if this is okay with you @mauron85 or you want to look for a better solution with some recovery scenario.

[mauron85]

Yes, please submit PR.

[ivosabev]

Seems code has changed significantly since then, I will close the issue.

[ivosabev]

I actually found a place where a null check is missing and submitted a PR (mauron85/background-geolocation-android#17)