Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: session store from issue #57 #64

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: session store from issue #57 #64

merged 2 commits into from
Feb 7, 2024

Conversation

rsdeus
Copy link
Collaborator

@rsdeus rsdeus commented Jan 18, 2024

This PR fixes the issue #57 by installing the activerecord_session_store - https://github.com/rails/activerecord-session_store.

@rsdeus rsdeus requested a review from RCheesley January 18, 2024 09:54
@rsdeus rsdeus self-assigned this Jan 18, 2024
@froger
Copy link
Collaborator

froger commented Jan 18, 2024

Hi @rsdeus I can't see any migrations files in this PR. I was expecting some after rails generate active_record:session_migration execution locally. Can you check this?

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, could you share how it is possible to test? I guess it's a bit tricky given that it's quite a transient error which isn't affecting everyone.

@rsdeus
Copy link
Collaborator Author

rsdeus commented Jan 18, 2024

Hi @rsdeus I can't see any migrations files in this PR. I was expecting some after rails generate active_record:session_migration execution locally. Can you check this?

Sorry @froger , here is the migration file
main...fix/session_store

@froger
Copy link
Collaborator

froger commented Feb 7, 2024

Thanks for looking into this, could you share how it is possible to test? I guess it's a bit tricky given that it's quite a transient error which isn't affecting everyone.

Hi @RCheesley yes it is not really testable as it is. But I have reviewed and it looks fine to me.
I am setting up a testing environment to be sure nothing breaks.

@froger froger closed this Feb 7, 2024
@froger froger reopened this Feb 7, 2024
@froger froger merged commit 1399db3 into main Feb 7, 2024
@froger froger deleted the fix/session_store branch February 7, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants