Add portal to cache also when creating a portal from the matrix side #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltee1
force-pushed
the
portal_to_cache_on_matrix_side_create
branch
from
6705bbb
to
21a0d80
Compare
|
This seems to only handle creating chats, while the original issue was about manually bridging 🤔 |
|
The |
tulir
approved these changes
Apr 8, 2023
mautrix_telegram/portal.py
Outdated
Comment on lines
568
to
574
| error_list = "\n".join(f"* [{mxid}](https://matrix.to/#/{mxid})" for mxid in errors) | ||
| await self.az.intent.send_notice( | ||
| self.mxid, | ||
| f"Failed to add the following users to the chat:\n\n{error_list}\n\n" | ||
| "You can try `$cmdprefix+sp search -r <username>` to help the bridge find " | ||
| "those users.", | ||
| ) |
There was a problem hiding this comment.
send_notice doesn't parse markdown automatically
maltee1
force-pushed
the
portal_to_cache_on_matrix_side_create
branch
from
453a691
to
1c1c6cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
I also moved the call to
get_telegram_users_from_matrix_room()tocreate_telegram_chat()to reduce code doubling and parameters passed to the latter function, because I had to touch that part anyway. I didn't see a good reason not to.