Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out pre-arm messaging system #3460

Open
DonLakeFlyer opened this issue Jun 1, 2016 · 2 comments
Open

Work out pre-arm messaging system #3460

DonLakeFlyer opened this issue Jun 1, 2016 · 2 comments
Assignees

Comments

@DonLakeFlyer
Copy link
Contributor

DonLakeFlyer commented Jun 1, 2016

Currently ArduPilot has a pre-arm messaging system which QGC knows about. PX4 stack does not. I'll fill in details in a bit.

@DonLakeFlyer DonLakeFlyer added this to the Release v3.0 milestone Jun 1, 2016
@DonLakeFlyer DonLakeFlyer self-assigned this Jun 1, 2016
@DonLakeFlyer
Copy link
Contributor Author

Ok, here is how ArduPilot works:

  • ArduPilot sends out STATUS_TEXT messages on a continuous basis when the Vehicle is not ready to arm. The reasons for not being able to arm are many: sensors not calibrated, not enough satellites, compass variance, on and on. Each of these tends to have a circuit breaker to turn the check off. The status message is user friendly and tells the user what the problem is.
  • ArduPilot will send the message once ever 10 seconds
  • Solo build sends every second and uses these to drive the UI of their custom remote
  • You don't have to attempt an Arm to start getting this messages. You start getting them as soon as you connect.
  • All of the messages start with "PreArm:"
  • QGC filters the "PreArm" messages in FirmwarePlugin placing the message in the center of the Fly map instead of using the normal ui mechanism.
  • QGC times out the "PreArm" message on the Fly map if it doesn't get another "PreArm" message with that same text
  • Note that this is all just visual indication. QGC does not know anything about what these messages mean and does not use them to prevent the user from attempting to Arm.
  • If the user attempts to Arm the command will fail, and the vehicle will send command failure ack. With the reason for the failure then sitting as text in the middle of the map.

The key here is that QGC doesn't attempt to understand when a command, whether it be Arm or say Flight Mode change will fail. It's a slippery slope to try to make QGC too smart with respect to that sort of thing. I'd rather keep QGC dumb and use something like ArduPilot does or create a new thing. Whatever the new thing is it's needs a simple indication whether arm is available as well as a text message as to why (as opposed t0 having QGC check multiple things to make a determination).

@DonLakeFlyer DonLakeFlyer modified the milestones: Release V3.2, Release V3.1 Nov 11, 2016
@DonLakeFlyer DonLakeFlyer modified the milestone: Release V3.2 Apr 6, 2017
@JonReacher
Copy link

JonReacher commented Oct 16, 2017

@DonLakeFlyer Any progress with this? It would be very helpful to have a ready to arm indication in QGC for PX4 for vehicles that have the autopilot/LED covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants