-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make chain
a class like the standard sync chain
#103
Make chain
a class like the standard sync chain
#103
Conversation
Fixes [GH#102](#102). Signed-off-by: William So <polyipseity@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 20 20
Lines 2012 2017 +5
Branches 307 308 +1
=======================================
+ Hits 1997 2002 +5
Misses 10 10
Partials 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go. Thank you for your contribution, I will merge this later on and prepare a release soon.
See [maxfischer2781/asyncstdlib#103](maxfischer2781/asyncstdlib#103). Signed-off-by: William So <polyipseity@gmail.com>
There are still an inconsistency between the this version and the sync version:
from_iterable()
to invoke an native constructor not exposed in Python, so they can returnchain[T]
. This version simply returns aAsyncIterator[T]
instead ofchain[T]
.Fixes #102.