-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests stubs #140
Fix tests stubs #140
Conversation
859abc4
to
3943ece
Compare
3943ece
to
862682a
Compare
Good catch. I'll try and review this ASAP. |
As a first glance, can you switch from the MyPy assertion plugin to using |
862682a
to
86f8633
Compare
I wasn't aware of this new function, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The only thing left to do is cleanup of unused dependencies.
Co-authored-by: Max Fischer <maxfischer2781@gmail.com>
Sorry, forgot to clean up, done |
54a00b7
to
d6e4ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go. Thanks for spotting this issue and for your contribution! 👍
The current typing yield the following error:
Related to python/mypy#10301
I also took time to add a typing test for every function in itertools that validate the iterator type. I added a dependency to
mypy-type-assets
to easily assert the type.