Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check response by schema #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sanchoyzer
Copy link

Added the ability to validate the response using schemas

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #97 into master will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   95.91%   96.41%   +0.49%     
==========================================
  Files           8        8              
  Lines         245      251       +6     
==========================================
+ Hits          235      242       +7     
+ Misses         10        9       -1     
Impacted Files Coverage Δ
aiohttp_apispec/middlewares.py 91.17% <100.00%> (+1.89%) ⬆️
aiohttp_apispec/aiohttp_apispec.py 95.65% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4697941...90ea591. Read the comment docs.

@maximdanilchenko
Copy link
Owner

@Sanchoyzer thanks for the PR!
Could you please make this checking to be optional?

@Sanchoyzer
Copy link
Author

@maximdanilchenko I have tried, but it seems that there is a bug which blocked me #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants