[WIP] Add resettable interface for Collectors #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be still relevant for Octane etc. also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is aimed specifically for https://github.com/php-pm/php-pm but could be used for other concurrent request frameworks (which I don't know of).
Adds a
reset()method to the collectors to reset the state. Eg. clear the messages, reset starting time etc.Not all collectors have been done yet, not all need it.
This can be used like
$debugbar->reset()to reset all collectors, the collected data and regenerate an request id.For Laravel this can be called in the middleware, after handling the request. For PHP-PM, this avoids duplicate entries etc.