Add environment variables for conf_file and database_dir #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
requested changes
May 25, 2021
|
Done @oschwald ;) |
oschwald
added a commit
that referenced
this pull request
Jun 3, 2021
oschwald
added a commit
that referenced
this pull request
Jun 3, 2021
oschwald
added a commit
that referenced
this pull request
Jul 20, 2021
4.8.0
* The Docker container now supports the following new environment
variables:
* `GEOIPUPDATE_CONF_FILE` - The path where the configuration file will
be written. The default is `/etc/GeoIP.conf`.
* `GEOIPUPDATE_DB_DIR` - The directory where geoipupdate will download
the databases. The default is `/usr/share/GeoIP`.
Pull request by Maxence POULAIN. GitHub #143.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #142, I also needed to run this container with another user therefore with another conf_file.
So I added a possible override on both conf_file and database_dir via environment variables.
Let me know if this is ok for you or if you need another commit to fix something.
Regards,