Speed up expand_directories function #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a directory with 1411 valid files, the new implementation using
os.scandir
took simply 8ms. The previous implementation for the same project would found more files (6692) but most of them not valid ones.Here are the results using different implementations:
and here is the code for this: https://gist.github.com/mazulo/f1fe5047fda3ab3a8f965ddfb7e39f2a