Merging installer changes required for autoupdate to function #1
Conversation
This reverts commit 09199fc.
… config flie HAS to be named CustomAction.config else Wix ignores it
Also modified update.sh to be an executable(using chmod), so that it can be run as a script
…ts-shell into mbhavi-miglani/autoUpdate
…into mbhavi-miglani/autoUpdate
This should fix the issue where the dmg windwow looks wrong on mounting it
| @@ -46,6 +46,16 @@ | |||
| <key>type</key> | |||
| <string>file</string> | |||
| </dict> | |||
| <dict> | |||
There was a problem hiding this comment.
@gavankar can you verify this layouting change and see if it's correct. The DMG GUI layout is getting messed up on my machine when I simply mount it. The container bounds seem to be off.
@ayushrathi15 can you confirm this issue?
There was a problem hiding this comment.
This layout change was added after this bug was found, to fix this bug
| @@ -15,6 +15,12 @@ rm -rf $tempDir | |||
| mkdir $tempDir | |||
| cp -r "./staging/${BRACKETS_APP_NAME}.app/" "$tempDir/$appName" | |||
|
|
|||
| # copy update.sh to hidden location in the dmg | |||
| if [ -f ./update.sh ]; then | |||
| echo "Adding update.sh" | |||
There was a problem hiding this comment.
@gavankar, it would be safer to give the file "executable" permissions(chmod) programmatically before copying. Since we would simply be invoking the script later on, we don't want to end up in a situation where the script is present but is not executable due to any number of reasons.
| } | ||
| else | ||
| { | ||
| session["UPDATEPATH"] = "0"; |
There was a problem hiding this comment.
@gavankar In case we are unable to read the values from registry, I am seeing that we're defaulting to 0. Has this workflow been confirmed with upper management. Because the default values in case of a fresh launch I think is 1.
@ayushrathi15 can you confirm this as well?
There was a problem hiding this comment.
@mbhavi Adding Brackets to the system path is an optional feature in the installer.
This piece of code is used to figure out what an upgrading user chose the last time they ran the installer, not what the option should be for a new user.
If we see that Brackets is already on the path, updatepath is set to 1 and we continue to keep Brackets on the path. If brackets is not on the path then, we shouldn't add it now and updatepath is set to 0.
There was a problem hiding this comment.
@gavankar , I think my comment was misunderstood. What i meant was, if we are unable to read the registry, irrespective of whatever value it contains, what are we doing with the registry entries? Do we default them back to 0, or do we don't do anything? If we don't touch the registry entries, does the installer at the time of update, pick up the already existing entries, so that the user selected options are kept intact for the new version as well?
How are you handling this case here?
There was a problem hiding this comment.
@mbhavi, in this piece of code we are not directly reading entries from the registry. We are asking the msi installer for a copy of the entries that it has loaded as part of its execution, this is very unlikely to fail.
These commits contain all the installer changes required on win and mac for autoupdate