Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox #1

Draft
wants to merge 292 commits into
base: master
Choose a base branch
from
Draft

sandbox #1

wants to merge 292 commits into from

Conversation

mbien
Copy link
Owner

@mbien mbien commented Nov 8, 2023

No description provided.

@mbien mbien added the LSP label Nov 8, 2023
@mbien mbien force-pushed the clone-build branch 2 times, most recently from e18b4cd to 637fd04 Compare November 8, 2023 10:19
@mbien mbien added Gradle and removed LSP labels Feb 2, 2024
Repository owner locked and limited conversation to collaborators Feb 2, 2024
Repository owner unlocked this conversation Feb 2, 2024
@mbien mbien force-pushed the clone-build branch 2 times, most recently from dec9015 to 66d417d Compare February 2, 2024 15:59
@mbien mbien added the LSP label Feb 2, 2024
@mbien mbien force-pushed the clone-build branch 3 times, most recently from e5282b5 to a127123 Compare February 10, 2024 04:01
@mbien mbien removed the Platform label Feb 10, 2024
@mbien mbien removed the ci:all-tests label Apr 1, 2024
sdedic and others added 14 commits September 30, 2024 13:44
Warn if JDK appears invalid and offer configuration.
Added code preview for “find usages” and related refactorings
…ress

commons-compress dependecy on commons-codec and commons-lang3 was missing
VSNetBeans 23.9.9 changelog update
Attempt to verify that Java exists, and is new enough
Test has a fairly high failure rate, investigation showed that
it had multiple issues. Fixing those does seem to improve stability,
however, likely does not fix the underlying race condition. With the
changes applied, 1 out of of 50 local runs failed.

But what is more important: the test is hopefully working correctly now

issues fixed:

'code.replaceFirst("^", "")' was used by accident. This method expects
regexps and won't have the desired effect. This essentially means
that the first parsing run had always javac errors since the test code
contained '^' characters.

The second parsing run, which did replace the injected snippet had
and off-by-one copy/paste mistake in one of the doRun methods.

But since the first run was already wrong, the result of reparse run
didn't really matter since both were compared - that is also why the
missing semicolon wasn't noticed in testAnonymousFullReparse2() or
the double escaped newline character in testAnonymous().

More asserts added to exclude potential document update issues.
@mbien mbien added bug Something isn't working and removed Maven labels Oct 2, 2024
@mbien mbien force-pushed the clone-build branch 2 times, most recently from 9731cd7 to b4407c6 Compare October 2, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.