forked from apache/netbeans
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sandbox #1
Draft
mbien
wants to merge
292
commits into
master
Choose a base branch
from
clone-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
sandbox #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
force-pushed
the
clone-build
branch
2 times, most recently
from
November 8, 2023 10:19
e18b4cd
to
637fd04
Compare
Repository owner
locked and limited conversation to collaborators
Feb 2, 2024
Repository owner
unlocked this conversation
Feb 2, 2024
mbien
force-pushed
the
clone-build
branch
2 times, most recently
from
February 2, 2024 15:59
dec9015
to
66d417d
Compare
mbien
force-pushed
the
clone-build
branch
3 times, most recently
from
February 10, 2024 04:01
e5282b5
to
a127123
Compare
Warn if JDK appears invalid and offer configuration.
Micronaut support: minor enhancements.
Added code preview for “find usages” and related refactorings
…ress commons-compress dependecy on commons-codec and commons-lang3 was missing
Fix NavigatorPanelImpl for LSP Client after 47d411b
VSNetBeans 23.9.9 changelog update
Attempt to verify that Java exists, and is new enough
Test has a fairly high failure rate, investigation showed that it had multiple issues. Fixing those does seem to improve stability, however, likely does not fix the underlying race condition. With the changes applied, 1 out of of 50 local runs failed. But what is more important: the test is hopefully working correctly now issues fixed: 'code.replaceFirst("^", "")' was used by accident. This method expects regexps and won't have the desired effect. This essentially means that the first parsing run had always javac errors since the test code contained '^' characters. The second parsing run, which did replace the injected snippet had and off-by-one copy/paste mistake in one of the doRun methods. But since the first run was already wrong, the result of reparse run didn't really matter since both were compared - that is also why the missing semicolon wasn't noticed in testAnonymousFullReparse2() or the double escaped newline character in testAnonymous(). More asserts added to exclude potential document update issues.
mbien
force-pushed
the
clone-build
branch
2 times, most recently
from
October 2, 2024 22:57
9731cd7
to
b4407c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.