only use attr_accessible if it's supported #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 4 doesn't define the ActiveModel::MassAssignmentSecurity constant, but there is a gem that allows it to be used. The models will now only try to use the functionality if the constant is defined
|
I like this a lot. |
|
The only other thing is that the gemspec in the repo says it only supports rails 3. Can we tag the current version as 2.4 and make master 3.0 so I can source it in the Gemfile of my Rails 4 project? |
|
With a fix this simple I don't think I even want to wait for 3.0 but just release it as-is. Then for 3.0 I can drop Ruby 1.8 support. I want to do a few more tests but this will definitely be merged this weekend. |
|
Sounds good. I'll wait until then. 😄 Thanks! |
|
Nice one. Still a few deprecation notices though, but it looks like we can fix them backwards compatible too. I will set up rails 4 branch on Travis CI and we're now fully supporting Rails 4! Thank you very much for your contribution, sir! |
tilsammans
added a commit
that referenced
this pull request
Apr 20, 2013
only use attr_accessible if it's supported
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
only use attr_accessible if it's supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 4 doesn't define the ActiveModel::MassAssignmentSecurity constant, but
there is a gem that allows it to be used. The models will now only try to use
the functionality if the constant is defined
fixes #334