Refactored to go back to sub selects #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tilsammans This pull request reverts the change in #324 that caused a performance regression. Would be great if you could merge it back to master and release an update. |
|
I'm sorry, I missed this pull request just now. It didn't make it into 2.4.1. I have to merge it manually anyway but I don't think that will be a problem. Should be some time in the next few days. |
|
Can you please rebase against master? There have been changes in this area of the code and I can see exactly what needs to stay and what needs to go. Thanks! |
|
The commits have been rebased and pushed. |
tilsammans
added a commit
that referenced
this pull request
May 15, 2013
Refactored to go back to sub selects
|
Thank you very much! |
|
No worries sir. Gotta keep the libraries fast =) |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Refactored to go back to sub selects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches back to sub selects, and also has an optimization where it doesn't do the sub select if it already knows the exact object id.