Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix as_8bit_ascii changes argument's encoding #456

Merged
merged 2 commits into from
Jan 9, 2014

Conversation

znz
Copy link
Contributor

@znz znz commented Jan 8, 2014

I met encoding problem after save.

Example in rails console:

>> post.tag_list = ["\u3042"]
=> ["あ"]
>> post.tag_list[0].encoding
=> #<Encoding:UTF-8>
>> post.save
(snip queries)
=> true
>> post.tag_list[0].encoding
=> #<Encoding:ASCII-8BIT>

And logger says log writing failed. "\xE3" from ASCII-8BIT to UTF-8 when running specs.

@jpalumickas
Copy link

👍

@bf4
Copy link
Collaborator

bf4 commented Jan 8, 2014

Would you mind adding a line for this to the CHANGELOG? Thanks

@znz
Copy link
Contributor Author

znz commented Jan 9, 2014

I added.

If CONTRIBUTING file exists, contributors can know it before creating pull request.
see https://github.com/blog/1184-contributing-guidelines

@bf4
Copy link
Collaborator

bf4 commented Jan 9, 2014

@znz You are right. Someone needs to write that up. :)

bf4 added a commit that referenced this pull request Jan 9, 2014
…ncoding

[Fix] as_8bit_ascii changes argument's encoding
@bf4 bf4 merged commit feedade into mbleigh:master Jan 9, 2014
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
…ments-encoding

[Fix] as_8bit_ascii changes argument's encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants