Match_all respects context #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump |
|
I just finished testing this PR, 👍 |
bf4
added a commit
that referenced
this pull request
Mar 12, 2014
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Match_all respects context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found what I think is a bug when using
match_allwith a context. Previously with a query likeOnly TaggedModels which had css as the only tag in any context would be returned, excluding models which had tags in other contexts, but only css in the skills context. With these changes
match_allonly applies to a specific context if one is given.Supercedes #486.